Download & Extend

Rename node, filter and comment modules tables to singular

Project:Drupal core
Version:7.x-dev
Component:base system
Category:task
Priority:normal
Assigned:recidive
Status:closed (fixed)
Issue tags:Needs Update Documentation

Issue Summary

As explained in #140860, for consistency we need all tables to be in singular.

Here is a patch that renames node.module's table {node_revisions} to {node_revision}, filter.module's {filters} to {filter} and {filter_formats} to {filter_format}, and comment.module's {comments} table to {comment}.

All tests pass.

AttachmentSizeStatusTest resultOperations
drupal_singular_comment_node_filter_tables.patch50.9 KBIdleFailed: Failed to apply patch.View details

Comments

#1

Status:needs review» needs work

The last submitted patch failed testing.

#2

Status:needs work» needs review

Re-testing now that HEAD is fixed.

#3

Status:needs review» needs work

The last submitted patch failed testing.

#4

Status:needs work» needs review

Testbot result is very strange : the patch should be applied properly.

Reroll (please do no credit me).

AttachmentSizeStatusTest resultOperations
issue-335086.patch53.59 KBIdleFailed: Failed to apply patch.View details

#5

Status:needs review» needs work

The last submitted patch failed testing.

#6

Status:needs work» needs review

Refreshing.

AttachmentSizeStatusTest resultOperations
drupal_singular_comment_node_filter_tables.patch52.02 KBIdlePassed: 7446 passes, 0 fails, 0 exceptionsView details

#7

Refreshing.

AttachmentSizeStatusTest resultOperations
drupal_singular_comment_node_filter_tables.patch52.02 KBIdleUnable to apply patch drupal_singular_comment_node_filter_tables_1.patchView details

#8

Was this committed (http://drupal.org/cvs?commit=156557)? The last patch isn't back from the testing bot yet, and this issue is still marked as code needs review...

#9

Status:needs review» fixed

Yes, this was commited. The latest patch was just a re-roll to remove offset.

Thanks!

#10

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

#11

Status:closed (fixed)» needs work

It looks like none of this was documented on http://drupal.org/update/modules/6/7

#12

changing tagging scheme for update guide

#13

Status:needs work» needs review

Section added: http://drupal.org/update/modules/6/7#table_names

#14

Status:needs review» fixed

Looks good to me, thanks!

#15

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here