Posted by recidive on November 16, 2008 at 8:28pm
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | base system |
| Category: | task |
| Priority: | normal |
| Assigned: | recidive |
| Status: | closed (fixed) |
| Issue tags: | Needs Update Documentation |
Issue Summary
As explained in #140860, for consistency we need all tables to be in singular.
Here is a patch that renames node.module's table {node_revisions} to {node_revision}, filter.module's {filters} to {filter} and {filter_formats} to {filter_format}, and comment.module's {comments} table to {comment}.
All tests pass.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| drupal_singular_comment_node_filter_tables.patch | 50.9 KB | Idle | Failed: Failed to apply patch. | View details |
Comments
#1
The last submitted patch failed testing.
#2
Re-testing now that HEAD is fixed.
#3
The last submitted patch failed testing.
#4
Testbot result is very strange : the patch should be applied properly.
Reroll (please do no credit me).
#5
The last submitted patch failed testing.
#6
Refreshing.
#7
Refreshing.
#8
Was this committed (http://drupal.org/cvs?commit=156557)? The last patch isn't back from the testing bot yet, and this issue is still marked as code needs review...
#9
Yes, this was commited. The latest patch was just a re-roll to remove offset.
Thanks!
#10
Automatically closed -- issue fixed for two weeks with no activity.
#11
It looks like none of this was documented on http://drupal.org/update/modules/6/7
#12
changing tagging scheme for update guide
#13
Section added: http://drupal.org/update/modules/6/7#table_names
#14
Looks good to me, thanks!
#15
Automatically closed -- issue fixed for 2 weeks with no activity.