Rename node, filter and comment modules tables to singular

recidive - November 16, 2008 - 20:28
Project:Drupal
Version:7.x-dev
Component:base system
Category:task
Priority:normal
Assigned:recidive
Status:closed
Description

As explained in #140860, for consistency we need all tables to be in singular.

Here is a patch that renames node.module's table {node_revisions} to {node_revision}, filter.module's {filters} to {filter} and {filter_formats} to {filter_format}, and comment.module's {comments} table to {comment}.

All tests pass.

AttachmentSize
drupal_singular_comment_node_filter_tables.patch50.9 KB
Testbed results
drupal_singular_comment_node_filter_tables.patchfailedFailed: Failed to apply patch. Detailed results

#1

System Message - November 16, 2008 - 20:40
Status:needs review» needs work

The last submitted patch failed testing.

#2

webchick - November 17, 2008 - 05:45
Status:needs work» needs review

Re-testing now that HEAD is fixed.

#3

System Message - November 17, 2008 - 21:30
Status:needs review» needs work

The last submitted patch failed testing.

#4

lilou - November 17, 2008 - 21:57
Status:needs work» needs review

Testbot result is very strange : the patch should be applied properly.

Reroll (please do no credit me).

AttachmentSize
issue-335086.patch 53.59 KB
Testbed results
issue-335086.patchfailedFailed: Failed to apply patch. Detailed results

#5

System Message - November 23, 2008 - 06:30
Status:needs review» needs work

The last submitted patch failed testing.

#6

recidive - December 2, 2008 - 19:47
Status:needs work» needs review

Refreshing.

AttachmentSize
drupal_singular_comment_node_filter_tables.patch 52.02 KB
Testbed results
drupal_singular_comment_node_filter_tables.patchpassedPassed: 7446 passes, 0 fails, 0 exceptions a href=http://testing.drupal.org/pifr/file/1/drupal_singular_comment_node_filter_tables_0.patchDetailed results/a

#7

recidive - December 3, 2008 - 16:03

Refreshing.

AttachmentSize
drupal_singular_comment_node_filter_tables.patch 52.02 KB

#8

Dave Reid - December 3, 2008 - 17:40

Was this committed (http://drupal.org/cvs?commit=156557)? The last patch isn't back from the testing bot yet, and this issue is still marked as code needs review...

#9

recidive - December 3, 2008 - 17:50
Status:needs review» fixed

Yes, this was commited. The latest patch was just a re-roll to remove offset.

Thanks!

#10

System Message - December 17, 2008 - 18:41
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.