As explained in #140860, for consistency we need all tables to be in singular.

Here is a patch that renames node.module's table {node_revisions} to {node_revision}, filter.module's {filters} to {filter} and {filter_formats} to {filter_format}, and comment.module's {comments} table to {comment}.

All tests pass.

CommentFileSizeAuthor
#7 drupal_singular_comment_node_filter_tables.patch52.02 KBrecidive
#6 drupal_singular_comment_node_filter_tables.patch52.02 KBrecidive
#4 issue-335086.patch53.59 KBlilou
drupal_singular_comment_node_filter_tables.patch50.9 KBrecidive
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs work » Needs review

Re-testing now that HEAD is fixed.

Status: Needs review » Needs work

The last submitted patch failed testing.

lilou’s picture

lilou CreditAttribution: lilou commented
Status: Needs work » Needs review
FileSize
issue-335086.patch53.59 KB

Testbot result is very strange : the patch should be applied properly.

Reroll (please do no credit me).

Status: Needs review » Needs work

The last submitted patch failed testing.

recidive’s picture

recidive CreditAttribution: recidive commented
Status: Needs work » Needs review
FileSize
drupal_singular_comment_node_filter_tables.patch52.02 KB

Refreshing.

recidive’s picture

recidive CreditAttribution: recidive commented
FileSize
drupal_singular_comment_node_filter_tables.patch52.02 KB

Refreshing.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Was this committed (http://drupal.org/cvs?commit=156557)? The last patch isn't back from the testing bot yet, and this issue is still marked as code needs review...

recidive’s picture

recidive CreditAttribution: recidive commented
Status: Needs review » Fixed

Yes, this was commited. The latest patch was just a re-roll to remove offset.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Closed (fixed) » Needs work
Issue tags: +Needs documentation

It looks like none of this was documented on http://drupal.org/update/modules/6/7

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Issue tags: -Needs documentation +Needs documentation updates

changing tagging scheme for update guide

sheilaj’s picture

sheilaj CreditAttribution: sheilaj commented
Status: Needs work » Needs review

Section added: http://drupal.org/update/modules/6/7#table_names

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Fixed

Looks good to me, thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Needs documentation updates

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Needs documentation updates

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.