As explained in #140860, for consistency we need all tables to be in singular.
Here is a patch that renames node.module's table {node_revisions} to {node_revision}, filter.module's {filters} to {filter} and {filter_formats} to {filter_format}, and comment.module's {comments} table to {comment}.
All tests pass.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | drupal_singular_comment_node_filter_tables.patch | 52.02 KB | recidive |
| #6 | drupal_singular_comment_node_filter_tables.patch | 52.02 KB | recidive |
| #4 | issue-335086.patch | 53.59 KB | lilou |
| drupal_singular_comment_node_filter_tables.patch | 50.9 KB | recidive |
Comments
Comment #2
webchickRe-testing now that HEAD is fixed.
Comment #4
lilou commentedTestbot result is very strange : the patch should be applied properly.
Reroll (please do no credit me).
Comment #6
recidive commentedRefreshing.
Comment #7
recidive commentedRefreshing.
Comment #8
dave reidWas this committed (http://drupal.org/cvs?commit=156557)? The last patch isn't back from the testing bot yet, and this issue is still marked as code needs review...
Comment #9
recidive commentedYes, this was commited. The latest patch was just a re-roll to remove offset.
Thanks!
Comment #11
jhodgdonIt looks like none of this was documented on http://drupal.org/update/modules/6/7
Comment #12
jhodgdonchanging tagging scheme for update guide
Comment #13
sheilaj commentedSection added: http://drupal.org/update/modules/6/7#table_names
Comment #14
jhodgdonLooks good to me, thanks!