Replace hardcoded file sizes with DRUPAL_KILOBYTE

Nice one!

I'm wandering if the 1024 byte fread()'s are sane candidates for the DRUPAL_KILOBYTE, though...

-H-

we also need to test with DRUPAL_KILOBYTE set to 1000, to see if there are any possible problems in the future...

quick context review

common.inc - file.inc - locale.inc
fread() and fgets() almost certainly should be working with 1024 (DRUPAL_KIBIBYTE anyone?)

blogapi.module
$usersize and $uploadsize are probaly proper changes.

filter.module
also, almost certainly should be working with DRUPAL_KIBIBYTE

simpletest.install
Certainly should be DRUPAL_KIBIBYTE, as it is clearly using powers of 2

file.test - upload.admin.inc - upload.module - upload.test - user.module - user.test
almost certainly proper changes!

also... there are some unrelated changes in your file.

Defining a DRUPAL_KIBIBYTE seems like a good idea. At first both the Kilobyte and the Kibibyte will be 1024 bytes...

Later (php 6?) Drupal can change the Kilobyte to 1000...

Late August, even Apple decided to change Mac OS X v10.6 to use 1000 bytes per kilobyte.

Isn't it time to fix Drupal's "wrong" kilobyte define yet?

define('DRUPAL_KILOBYTE', 1000);

I wonder when PHP itself will be making the switch? http://bugs.php.net/bug.php?id=46534

3 years later and Drupal 8.x is in -dev... What about correcting the kilobyte to what it should be in D8? ;)

1000!

Uh, yeah, because Drupal is hosted on Mac OSX. No.

Still agree Dave Reid's patch should go in :)
Although, probably needs a re-roll.

@pingers: what do you mean by "Uh, yeah, because Drupal is hosted on Mac OSX. No."?

For the record: 1 kilobyte equals 1000 bytes, just like 1 kilometer equals 1000 meters. The question is if Drupal should follow conventions and use the correct definition (1000) or make the same misstake as a lot of other implementations and lie about the value of a kilo (1024, which is a 'kibi').

See also: #1114538: Use SI and/or IEC units for byte counts?

It is my opinion, Drupal should always be using the correct SI and IEC units, except when handling a interface that does not handle those units correctly

@MrHaroldA What I mean is the most sensible option is to use the unit used by the most commonly used hosting OS. I.e. Linux and 1024 bytes in a kilobyte. Also this is the value used by the IEC standard noted in #12 (IEC = 2^10, SI = 10^3). Also, it has nothing to do with this issue. Please open a new issue to debate this. Feel free to link to it from this issue.

@pingers: IIRC, Linux uses the correct standard: 1000 bytes in a kB.

And no need for a new issue: #1114538: Use SI and/or IEC units for byte counts? covers it all...

$ dd if=/dev/zero of=testfile.txt bs=1K count=1
1+0 records in
1+0 records out
1024 bytes (1.0 kB) copied, 8.552e-05 s, 12.0 MB/s

Sorry, you're wrong.

@pingers: I notices that you use 'K' instead of 'k', which is also wrong in a SI approach. It's also silly to refer to an invalid application for the "truth" as dd should read "kiB" or "KB" for 1024 bytes as 1kB equals 1000 bytes.

The hosting OS has nothing to do with a website: the visiting OS is much more leading. I don't know what Windows is using these days, but OSX and a lot of Linux file managers already show correct SI sizes, with more to follow suit.

There are 2 options: use SI or IEC. PHP itself aready has plans to ditch IEC support and switch over to SI, why should our favorite CMS stay behind?

Got a link? If and when they do, I'd consider it a possibility.

Some nice reads:
http://drupal.org/node/267883#comment-1100817

drupal should follow standards closely, and change when standards are updated, as the drop is always moving, AND SHOUD NOT LAG BEHIND!

also, this has a usability impact, since using the same wording with two different meanings is JUST PLAIN WRONG, and should end RIGHT NOW, Regular users don't know that the units have dual meanings, and we shouldn't continue confusing them in this way.

also "man 7 units" on your linux-box ;)

https://bugs.php.net/bug.php?id=46534

Note that even Mac OS X v10.6 is using 1000 bytes per kilobyte. (http://support.apple.com/kb/TS2419)

Linux is using it for years already (units(8) manual page)

The only operating system still using 1024 for kilo is Microsoft Windows

I suggest we use the proper and full kilobyte and kibibyte definitions as soon as possible!

And even Dries agrees we should use SI instead of IEC: http://drupal.org/node/151902#comment-858570

Posted by Dries on May 27, 2008 at 9:30am
I'm OK with the patch in #5 but it could use a SimpleTest ...

There are three different filesizes we need to account for.

Memory sizes expressed in base-2 (IEC) units. (1kiB = 1024 bytes)
Disk sizes expressed in base-10 (SI) units. (1kB = 1000 bytes)
Shorthand sizes returned from PHP that use the wrong type (1k for 1024) such as the memory_limit setting.

@alexanderpas #1114538: Use SI and/or IEC units for byte counts? handles all of those combinations.

I think this work has been completed in other issues, such as #3001398: format_size() fixes. I searched Drupal 10.0.x found 31 instances of 1024 (excluding files in a 'fixtures' directory) but I did not spot any one that needed to be changed. If I am wrong about that it would be better to open a new issue anyway because of the many code changes that have happened in the intervening 10 years.

I came here while triaging a related issue for bugsmash, adding tag.

Closing as outdated.