Damien mentioned that getActiveConnection does and then I realized it's copypasted.

CommentFileSizeAuthor
#3 335614.patch6.05 KBdamien tournoud
#2 335614.patch5.99 KBdamien tournoud
#1 335614.patch4.41 KBdamien tournoud
openconnection_key.patch633 byteschx

Comments

damien tournoud’s picture

damien tournoud commented
StatusFileSize
new 335614.patch4.41 KB

getActiveConnection() and getConnection() were buggy anyway: if called on a non existing target, openConnection() will be called each time, because the target will not be found in self::$connections

damien tournoud’s picture

damien tournoud commented
StatusFileSize
new 335614.patch5.99 KB

Bug description: all getConnection() twice with the same unknown $target... openConnection() is called twice...

Now with a unit test case.

damien tournoud’s picture

damien tournoud commented
StatusFileSize
new 335614.patch6.05 KB

Now with some less incorrect English.

dries’s picture

dries commented
Status: Needs review » Fixed

Makes sense, and the tests made it easy to understand and review. Committed to CVS HEAD. Thanks a lot.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.