Posted by andershal on November 18, 2008 at 9:32am
3 followers
| Project: | ImageCache |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
In _imagecache_apply_action() the specific action is applied by using call_user_func() even though the actions expects the $image to be passed by reference. Is it the actions which are implemented wrong or the use of call_user_func instead of call_user_func_array?
I my case I have a crop action which depends on another preset modifying the $image object. This patch solves that.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| call_user_func_reference.patch | 1.12 KB | Ignored: Check issue status. | None | None |
Comments
#1
if image is an object then it should be passed by reference right?
#2
Why not just ignore the whole call_user_func() bit? We don't have a dynamic number of arguments. Objects are passed by reference implicitly.
#3
committed the attached to HEAD.
#4
Automatically closed -- issue fixed for two weeks with no activity.