Thanks for the great module and your hard work.

Please take out the comma from Created year + month display results. The display is Ocotober, 2008. The editor where I work says it needs to be October 2008.

CommentFileSizeAuthor
#2 views_335926.patch807 bytesdrewish

Comments

sapark’s picture

sapark commented

I took out the comma between F and Y in the file views_handler_argument_dates_various.inc located at views/modules/node.

/**
 * Argument handler for a year plus month (CCYYMM)
 */
class views_handler_argument_node_created_year_month extends views_handler_argument_date {
  /**
   * Constructor implementation
   */
  function construct() {
    parent::construct();
    $this->format = 'F Y';
    $this->arg_format = 'Ym';
    $this->formula = views_date_sql_format($this->arg_format, "***table***.$this->real_field");
  }
drewish’s picture

drewish commented
Status: Active » Needs review
StatusFileSize
new views_335926.patch807 bytes

as a patch.

paul.lovvik’s picture

paul.lovvik commented
Status: Needs review » Reviewed & tested by the community

Looks good.

merlinofchaos’s picture

merlinofchaos commented
Status: Reviewed & tested by the community » Fixed

Committed after I couldn't find anybody to agree with me that the comma should be there.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

mgraesser’s picture

mgraesser commented

I am still getting this problem -- 'March, 2009' displays instead of 'March 2009'. Was this not fixed? (I have version 1.4 of views_handler_argument_dates_various.inc (2009-01-08) installed.)

drewish’s picture

drewish commented

mgraesser, are you sure you're using the view's dates support and not those of another contributed module?

mgraesser’s picture

mgraesser commented

Actually, not. I'm working with CCK+Date in creating a field in a content type. So that formatting is probably handled somewhere else, probably in Date. Any suggestions?

bartclarkson’s picture

bartclarkson commented

I ran into this, mgraesser, in doing some list style declaration in my arguments on a CCK date. Seems to consume the Long Date Format from your Date and Time settings. It would be nice to declare the date format inline within the arguments settings of the given view, but pretty low-priority, I'm sure.

xjm’s picture

xjm
she/her
Primary language English
commented

See also #656806: Commas in date summary views.