uc_taxes.js
cjpound - November 19, 2008 - 05:49
| Project: | UC Discounts |
| Version: | 5.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
Great module by the way.
Modules like these are one of the reasons I think Ubercart/Drupal are so great for eCommerce.
There is a call to the getTax() function (defined in uc_taxes.js) on line 339 of uc_discounts.module, but uc_taxes is not part of the core Ubercart installation, nor is it an installation requirement for uc_discounts. This results (for me) in a javascript error that prevents calculation of the order total on the checkout page (getTax() is not defined).
Installing uc_taxes (and therefore including uc_taxes.js and the getTax() function) fixes the problem, but also adds extra an unnecessary js file for those not using the uc_taxes module.
#1
Hmm ok, we recently added that cause the line items javascript calculation was not good, but I didn't think to add a condition for people not having tax module.
OK will be commited, need to commit it to 6.x too.
#2
#3
Automatically closed -- issue fixed for two weeks with no activity.