Closed (fixed)
Project:
FAQ_Ask
Version:
6.x-1.x-dev
Component:
User interface
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 Nov 2008 at 00:39 UTC
Updated:
14 Apr 2009 at 02:10 UTC
In the interests of consistancy, would it not be better to have the path to ask a question as faq/ask rather than faq_ask? Since there is a dependancy on the FAQ module this would make sence, and look tidier I feel.
Comments
Comment #1
nancydruWell, first, it's more in keeping with Drupal guidelines, although your argument does make sense. But then what do we do with 'faq_ask/answer/%node', 'faq_ask/edit/%node', and 'faq_ask/more'?
Comment #2
wretched sinner - saved by grace commentedWould it be possible to use faq/answer/%node, faq/edit/%node and faq/unanswered? I think these more clearly indicate what each path does, and ties it closer to the faq module.
I can also understand leaving them as is if that is the right way to do it by Drupal.
Comment #3
nancydruI have asked Stella to weigh in on this since she owns FAQ.
Comment #4
stella commentedHmmm, I'm not sure this will work because it would probably conflict with this menu item in the faq module:
It means that everything "faq/XXX" is handled by the faq_page() function. You'd have to test it to see could you override this setting, though I imagine it's the first matched menu path that is returned...
Comment #5
nancydruAh, good point, Stella. Although they claim "best match" on the 6.x menu system, I have seen cases where it really does either "first match" or "shortest match."
Comment #6
wretched sinner - saved by grace commentedThat makes sense then to use the faq_ask path.
@stella - can I ask why faq takes all the paths? I haven't played much with it, and am interested to know. Is it something that could be changed, enabling these changes?
Comment #7
stella commented@wretched sinner: FAQ module expects all 'faq/123' to be paths to categorized faq pages where 123 is the term id of the taxonomy term in question. However, it's not always a number - it can also be the term name or other text if path aliases are being used.
Cheers,
Stella
Comment #8
wretched sinner - saved by grace commentedThat makes sense.
I think the only way to change the paths for faq_ask would be to change the faq pages to be say faq/cat/% or similar, which I don't think is worth doing simply to tidy up faq_ask.
It was worth asking though!
Comment #9
nancydruI have worked in a bunch of different environments in my 30+ years of information technology, and I have to say that when Dries designed Drupal, it was pure genius. There are, however, some areas that maybe are less than perfect. All in all, though, I would say that the menu system is remarkably flexible, even if sometimes not quite enough.
Jerome, I'm leaving this issue open because your suggestions are worthy of consideration. Certainly I like "faq_ask/unanswered" better than "faq_ask/more" (which was named that because it is used by a "more" link). So, let's see if we can improve the menu items within the structure we have to work with.
Comment #10
nancydruComment #11
nancydruWith version 6.x-2.x, the menu has been streamlined. "Faq_ask/more" is now "faq_ask/unanswered." (And, BTW, it now does a node display on the full page.) The other paths you questioned are gone, but you may now see "?ask=true" in a few URLs, but I think that is sort of reminding the user that they are in question asking mode.
Comment #12
wretched sinner - saved by grace commentedThanks NancyDru!