Problem identified: Public vs Private Filestore

Thanks for an outstanding bug report! You thought of all the questions I would have asked and have answered them already! This bug report should be published somewhere as an example. :-)

The error you are receiving is actually being reported by the file_copy() function from files.inc, part of Drupal core. Luckily my module calls file_copy() directly rather than through an intermediary, so we can trace what's being passed to this function as parameters.

I've just now committed a new version of image_import.module to CVS that adds one new debugging statement, immediately before the file_copy() call, reporting exactly what we're passing to that function.

Please retrieve image_import.module from CVS and update your installation, then try again, and let me take a look at your debug output. Also, please provide the output of an "ls -ld" command on both of the parameters that are shown in the file_copy() call line. The new debug lines will look like this:

DEBUG: Invoking file_copy('image_import/cake.jpg', 'files/images', FILE_EXISTS_RENAME)

So in this example what we would need is the output of

ls -ld image_import/cake.jpg files/images

The "ls" command would of course be run from your Drupal root directory.

Thanks!

Scott

Have downloaded the new CVS version and replaced it in my modules directory. Version number is:

// $Id: image_import.module,v 1.15 2005/10/11 14:42:30 syscrusher Exp $

Began the same process of import. Preview shows:

Looks good so far. Now to import:

As you can see, the copy is being directed to an unknown location relative to the drupal home directory:

var/www/localhost/files/images

As expected, the ls -ld command you requested shows:

The question for me is where in the setup is this location being incorrectly specified relative to the drupal director rather than absolute to root, which would make it correct. I've checked the settings for image and for upload, and I've looked directly in the variables table in mysql but have not found this setting.

The problem above is caused by the assignment of $image_dir in line 723:

The _image_import_get_image_path function assumes a public filestore and returns a path relative to the drupal home directory. If a private filestore is used, it returns the absolute path minus its initial '/' which gets catenated incorrectly to the drupal home directory.

The problem in _image_import_get_image is the statement in line 773:

If a private filestore is used, it is not correct to remove the initial slash. I haven't tested it yet, but the following mod to _image_import_get_image should do the trick:

Great work, folks. I've committed the patch, kindly provided by rxfelix, to HEAD and to DRUPAL-4-6 branches. It should be in the download page by tomorrow, if all goes well.

Thanks for the debugging help. I don't have any sites using public filestore, and didn't realize the leading slash was handled differently. This is why the Open Source community process works so well. I appreciate your contribution, both in finding the bug and in fixing it.

Scott