ImagePicker is using the user name (creates folder from the name). This is not in line with what other modules are doing.

And anytime a user changes his username, all images are lost. Please consider using userid, as it is much more robust. I'll need to disable the neat feature that Drupal has, to allow users to change login name :-((

Comments

hutch’s picture

hutch commented
Assigned: Unassigned » hutch

Good point. Very good point in fact.
Implementing it for new installs is simple enough, making it backward-compatible is a bit trickier, I will think about this.

Also there are scalability issues to think about. Drupal is used on some large sites and large directory lists can cause problems on some filesystems.

Thanks for pointing this out.

PPLandry’s picture

PPLandry commented

You're welcomed. I forgot to thank you for an excellent module. It is working fine now, I got the FCKEditor issue fixed (image was not being inserted), so I'm one happy camper!

For backwards compatibility, it could be an option in the settings page: Radio button: Use UserID, Use UserName...

hutch’s picture

hutch commented

Did you use the patch from http://drupal.org/node/274093 to get fckeditor working?

As for backwards compatibility, I have started working on a conversion function and I agree that this is best implemented as an option. I am looking into the possibility of detecting wether it is a new install or an upgrade and if it is a new install using the UserID method by default. This would be for a 2.x version

I was concerned that using the UserID method could lead to problems with very large user bases, but came to the conclusion that sites running such systems would/should be using a filesystem that can cope.
With ext3 for instance There is a limit of 31998 sub-directories per one directory, see http://en.wikipedia.org/wiki/Ext3

hutch’s picture

hutch commented
Status: Active » Closed (fixed)

imagepicker-5.x-2.x-dev now supports directory naming by userID