Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.This patch update modules/block/* as DBTNG syntax.
I have no idea about the revamp for db_rewrite_sql(), so left a comment message for that as:
// @todo: Revamp with DBTNG syntax.
| Comment | File | Size | Author |
|---|---|---|---|
| #23 | block.followup4.patch | 2.22 KB | berdir |
| #21 | block.followup3.patch | 2.22 KB | berdir |
| #18 | block.followup2.patch | 1.63 KB | berdir |
| #15 | block.followup.patch | 1.08 KB | berdir |
| #10 | 337212.dbtng_block.patch | 19.31 KB | berdir |
Comments
Comment #2
hswong3i commentedReroll based on CVS HEAD.
Comment #4
hswong3i commentedReroll based on CVS HEAD.
Comment #6
dropcube commentedI think is better to concentrate efforts first in #257032: Split block $ops into separate functions
Comment #7
Crell commentedReactiviating.
Comment #8
zoo33 commentedWow. Duplicated efforts:
#302263: Rework block.module for the new data api
@hswong3i: If you want to compare notes or work together on this somehow, let me know. Both our patches need to be re-rolled.
But maybe dropcube is right about #257032: Split block $ops into separate functions
Comment #9
Crell commentedComment #10
berdirOk, another patch, also converted the dynamic queries and added a tag to the block loading query.
Comment #11
dries commentedCommitted to CVS HEAD. Thanks!
Comment #12
chx commentedWhy are we having explicit int casts for default values? They were not needed before. That's curious.
Comment #13
Crell commentedFALSE and NULL no longer auto-fold to int 1, so that has to be done explicitly. I do not want to do that automatically because of the performance hit.
Comment #14
chx commentedBut why in #default_value and not in the save routines...? And, in general, if we are using d_w_r which retrieves the schema anyways, then we could autocast there.
Comment #15
berdirNot sure, the first one is obviously needed, but I can't find a reason for these, manual testing and the block tests work, let's ask the test bot...
Comment #16
berdirComment #18
berdirOk, so that obviously doesn't work, not sure why my local tests did work though. Another try which converts the value only before saving...
Comment #19
berdirComment #21
berdirThis time for real, tests pass locally...
Comment #22
catchThere should be a space between the (int) and the $var.
Comment #23
berdirRe-roll with casting coding style fixed.
Comment #24
catchLooks good.
Comment #25
dries commentedCommitted to CVS HEAD. Thanks.