Download & Extend
Issues

DBTNG: Block module

Posted by hswong3i on November 21, 2008 at 5:58am
Project:Drupal core
Version:7.x-dev
Component:block.module
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:DBTNG Conversion

Issue Summary

This patch update modules/block/* as DBTNG syntax.

I have no idea about the revamp for db_rewrite_sql(), so left a comment message for that as:

<?php
// @todo: Revamp with DBTNG syntax.
?>
AttachmentSizeStatusTest resultOperations
dbtng-block-1227246997.patch14.1 KBIdleFailed: 7280 passes, 7 fails, 12 exceptionsView details
Login or register to post comments

Comments

#1

Posted by System Message on November 21, 2008 at 6:35am
Status:needs review» needs work

The last submitted patch failed testing.

#2

Posted by hswong3i on November 23, 2008 at 2:53am
Status:needs work» needs review

Reroll based on CVS HEAD.

AttachmentSizeStatusTest resultOperations
dbtng-block-1227408727.patch14.19 KBIdleFailed: 7421 passes, 7 fails, 12 exceptionsView details

#3

Posted by System Message on November 23, 2008 at 3:15am
Status:needs review» needs work

The last submitted patch failed testing.

#4

Posted by hswong3i on November 27, 2008 at 5:27am
Status:needs work» needs review

Reroll based on CVS HEAD.

AttachmentSizeStatusTest resultOperations
dbtng-block-1227763112.patch14.21 KBIdleFailed: Failed to apply patch.View details

#5

Posted by System Message on December 18, 2008 at 10:50am
Status:needs review» needs work

The last submitted patch failed testing.

#6

Posted by dropcube on December 27, 2008 at 6:04pm
Status:needs work» postponed

I think is better to concentrate efforts first in #257032: Split block $ops into separate functions

#7

Posted by Crell on March 7, 2009 at 7:08pm
Title:[DBTNG] revamp modules/block/* with DBTNG syntax» DBTNG: Block module
Status:postponed» active

Reactiviating.

#8

Posted by zoo33 on March 7, 2009 at 9:29pm

Wow. Duplicated efforts:

#302263: Rework block.module for the new data api

@hswong3i: If you want to compare notes or work together on this somehow, let me know. Both our patches need to be re-rolled.

But maybe dropcube is right about #257032: Split block $ops into separate functions

#9

Posted by Crell on March 7, 2009 at 9:34pm
Assigned to:hswong3i» Anonymous

#10

Posted by Berdir on May 28, 2009 at 10:31am
Status:active» needs review

Ok, another patch, also converted the dynamic queries and added a tag to the block loading query.

AttachmentSizeStatusTest resultOperations
337212.dbtng_block.patch19.31 KBIdleFailed: Failed to apply patch.View details

#11

Posted by Dries on May 28, 2009 at 11:31am
Status:needs review» fixed

Committed to CVS HEAD. Thanks!

#12

Posted by chx on May 28, 2009 at 4:43pm

Why are we having explicit int casts for default values? They were not needed before. That's curious.

#13

Posted by Crell on May 28, 2009 at 4:58pm

FALSE and NULL no longer auto-fold to int 1, so that has to be done explicitly. I do not want to do that automatically because of the performance hit.

#14

Posted by chx on May 28, 2009 at 5:16pm

But why in #default_value and not in the save routines...? And, in general, if we are using d_w_r which retrieves the schema anyways, then we could autocast there.

#15

Posted by Berdir on May 28, 2009 at 6:33pm

Not sure, the first one is obviously needed, but I can't find a reason for these, manual testing and the block tests work, let's ask the test bot...

AttachmentSizeStatusTest resultOperations
block.followup.patch1.08 KBIdleFailed: 11504 passes, 6 fails, 2 exceptionsView details

#16

Posted by Berdir on May 28, 2009 at 6:33pm
Status:fixed» needs review

#17

Posted by System Message on May 28, 2009 at 6:46pm
Status:needs review» needs work

The last submitted patch failed testing.

#18

Posted by Berdir on May 28, 2009 at 8:28pm

Ok, so that obviously doesn't work, not sure why my local tests did work though. Another try which converts the value only before saving...

AttachmentSizeStatusTest resultOperations
block.followup2.patch1.63 KBIdleFailed: 11504 passes, 6 fails, 2 exceptionsView details

#19

Posted by Berdir on May 28, 2009 at 9:07pm
Status:needs work» needs review

#20

Posted by System Message on May 28, 2009 at 10:10pm
Status:needs review» needs work

The last submitted patch failed testing.

#21

Posted by Berdir on May 28, 2009 at 10:15pm
Status:needs work» needs review

This time for real, tests pass locally...

AttachmentSizeStatusTest resultOperations
block.followup3.patch2.22 KBIdlePassed: 11510 passes, 0 fails, 0 exceptionsView details

#22

Posted by catch on May 29, 2009 at 7:56pm
Status:needs review» needs work

There should be a space between the (int) and the $var.

#23

Posted by Berdir on May 29, 2009 at 8:29pm
Status:needs work» needs review

Re-roll with casting coding style fixed.

AttachmentSizeStatusTest resultOperations
block.followup4.patch2.22 KBIdlePassed: 11510 passes, 0 fails, 0 exceptionsView details

#24

Posted by catch on May 29, 2009 at 8:55pm
Status:needs review» reviewed & tested by the community

Looks good.

#25

Posted by Dries on May 29, 2009 at 9:29pm
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks.

#26

Posted by System Message on June 12, 2009 at 9:30pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here