DBTNG: Block module
hswong3i - November 21, 2008 - 05:58
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | block.module |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
| Issue tags: | DBTNG Conversion |
Description
This patch update modules/block/* as DBTNG syntax.
I have no idea about the revamp for db_rewrite_sql(), so left a comment message for that as:
<?php
// @todo: Revamp with DBTNG syntax.
?>| Attachment | Size |
|---|---|
| dbtng-block-1227246997.patch | 14.1 KB |
| Testbed results | ||
|---|---|---|
| dbtng-block-1227246997.patch | failed | Failed: 7280 passes, 7 fails, 12 exceptions a href=http://testing.drupal.org/pifr/file/1/dbtng-block-1227246997.patchDetailed results/a |
#1
The last submitted patch failed testing.
#2
Reroll based on CVS HEAD.
#3
The last submitted patch failed testing.
#4
Reroll based on CVS HEAD.
#5
The last submitted patch failed testing.
#6
I think is better to concentrate efforts first in #257032: Blocks system refactoring
#7
Reactiviating.
#8
Wow. Duplicated efforts:
#302263: Rework block.module for the new data api
@hswong3i: If you want to compare notes or work together on this somehow, let me know. Both our patches need to be re-rolled.
But maybe dropcube is right about #257032: Blocks system refactoring
#9
#10
Ok, another patch, also converted the dynamic queries and added a tag to the block loading query.
#11
Committed to CVS HEAD. Thanks!
#12
Why are we having explicit int casts for default values? They were not needed before. That's curious.
#13
FALSE and NULL no longer auto-fold to int 1, so that has to be done explicitly. I do not want to do that automatically because of the performance hit.
#14
But why in #default_value and not in the save routines...? And, in general, if we are using d_w_r which retrieves the schema anyways, then we could autocast there.
#15
Not sure, the first one is obviously needed, but I can't find a reason for these, manual testing and the block tests work, let's ask the test bot...
#16
#17
The last submitted patch failed testing.
#18
Ok, so that obviously doesn't work, not sure why my local tests did work though. Another try which converts the value only before saving...
#19
#20
The last submitted patch failed testing.
#21
This time for real, tests pass locally...
#22
There should be a space between the (int) and the $var.
#23
Re-roll with casting coding style fixed.
#24
Looks good.
#25
Committed to CVS HEAD. Thanks.
#26
Automatically closed -- issue fixed for 2 weeks with no activity.