When path negotiation is set to country settings, clicking a language from the front page can lead to paths like <front>?language=ab I've not spotted this before, maybe a result of some of the recent changes?

CommentFileSizeAuthor
#2 country_code_front_404.patch1.01 KBcatch
#1 country_code_front_404.patch871 bytesrecidive

Comments

recidive’s picture

recidive commented
Status: Active » Needs review
StatusFileSize
new country_code_front_404.patch871 bytes

Attached patch fixes this.

I'm not quite sure if we should link to e.g. /ca, or get default frontpage using variable_get('site_frontpage', 'node') and append it to the path, e.g. ca/node. Country block does this this way.

catch’s picture

catch
he/him
Primary language English
commented
StatusFileSize
new country_code_front_404.patch1.01 KB

Patch had e-notice errors - undefined variable. Modified to use drupal_is_front_page(). I prefer /ca to the site_front_page variable - usually you want your front page to really be '/' rather than the arbitrary path which is being used to generate it. We should probably standardise either way though, and I'm not sure which is considered best practice.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Fixed

Commited #2.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.