In usercomment_comment_render() the construction of the link_alter call was incorrect it was calling the function with the parms in the wrong order.

It was this

      $function = $module .'_link_alter';
      $function($node, $links);

But, it should be 

      $function = $module .'_link_alter';
      $function($links, $node);

I'll work on creating a proper patch for this.

CommentFileSizeAuthor
#5 usercomment-alter-links-D6.patch502 bytesdave reid
#4 usercomment_linkalter.patch554 byteschuckdeal97
#1 usercomment_linkalter.patch443 byteschuckdeal97

Comments

chuckdeal97’s picture

chuckdeal97 commented
Assigned: Unassigned » chuckdeal97
Status: Active » Needs review
StatusFileSize
new usercomment_linkalter.patch443 bytes

Here is the patch. It is designed to be run from the usercomment module directory.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

It's actually preferred to use:

drupal_alter('link', $links, $node);

instead of:

    foreach (module_implements('link_alter') as $module) {
      $function = $module .'_link_alter';
      $function($node, $links);
    }
chuckdeal97’s picture

chuckdeal97 commented

Alright, thanks. When I get a minute, I'll give that a shot. I'm not the original author and I am just trying to get the module working up to snuff.

chuckdeal97’s picture

chuckdeal97 commented
StatusFileSize
new usercomment_linkalter.patch554 bytes

Ok, how about this then... uses drupal_alter

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Priority: Normal » Critical
StatusFileSize
new usercomment-alter-links-D6.patch502 bytes

Here's the patch for the current DRUPAL-6--1 branch (with the correct offset).

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Any progress on this bugfix?

chuckdeal97’s picture

chuckdeal97 commented

I have applied this fix to my code and it fixes the problem. I was hoping that someone other than me has applied and verified the solution.

I'm not the maintainer, and I don't know what the procedure for creating a new project release is, but there are a number of D6 patches that should be applied to this project, in addition to this one.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Yeah, looks like the maintainer is not active at all. The only code update in 2008 was one update in September.

gwen’s picture

gwen commented
Status: Needs review » Fixed

The code should be fixed in the latest dev snapshot.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Assigned: chuckdeal97 » Unassigned

Thanks very much gwen!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.