Update SMS sending method for new SMS Framework

diggersf - November 21, 2008 - 20:16
Project:Messaging
Version:6.x-2.2
Component:SMS Plugin
Category:bug report
Priority:critical
Assigned:Unassigned
Status:active
Issue tags:Release blocker
Description

This patch updates the SMS sending method to be compatible with the newest SMS Framework API on Drupal 6.

AttachmentSize
messaging_sms.patch1.8 KB

#1

Jose Reyero - January 22, 2009 - 18:14
Priority:normal» critical
Status:needs review» needs work

The sending method plug-ins have gone through some changes so this one no longer applies.

However, there's an issue with this approach. Though the user sending function takes an user/uid as argument, the generic sending callback should work with user-less destinations (like a phone number) so it can be used to send messages to non users too.

Take a look at the new 'destination callback' parameter, which is intended to translate user accounts into destination's

#2

Jose Reyero - January 26, 2009 - 16:16

#3

diggersf - January 30, 2009 - 18:20

Hey Jose. I think it makes sense just to pass on the whole $user->sms_user array to the send callback so it has direct access to it.

Is there a better way? I couldn't figure out how to use the $params variable in the send callback.

AttachmentSize
messaging_sms.diff 1.44 KB

#4

Jose Reyero - January 30, 2009 - 18:59
Status:needs work» fixed

Thanks Will, committed with a few minor changes (param checking, also did some cleaning in the old module's code.

About the $params variable, that's optional for sending methods that may need more params (like mail), no need to handle it unless it makes sense.

#5

System Message - February 13, 2009 - 19:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

#6

rothatboat - August 13, 2009 - 18:46

I continue to get the error with the 'carrier' not being added on for the email to send:

'Unable to send e-mail. Please contact the site administrator if the problem persists.'

The patch has not solved it, and I'm using the latest release of the sms framework. I have tried inputting the 'carrier' manually into the sms email gateway and that worked. But my users have various providers. Is there any solution to this problem on Drupal 6.13?

Thanks in advance.

#7

Daryljames - December 17, 2009 - 20:28
Version:6.x-1.x-dev» 6.x-2.2

This is definately still a bug in 6.x-2.2

#8

Daryljames - December 17, 2009 - 20:28
Status:closed» active

#9

Daryljames - December 17, 2009 - 20:38

I have it working if the user subscribes to tags... but not when they are subscribed to groups... it may have something to do with either notifications-lite, or organic groups notifications.

 
 

Drupal is a registered trademark of Dries Buytaert.