This patch fixes some bugs (you'd have to ask CHX what they are), but more importantly the use of define() is now gone,
and keywords are specified in the format of '#keyword'.

The documentation that has been written should take this into account.

CommentFileSizeAuthor
#5 formapi_minor_fix_r2.patch2.53 KBpfaocle
forms-api-keyword.patch318.34 KBadrian

Comments

chx’s picture

chx commented
Version: 4.6.3 » x.y.z

requredrequredrequred fixed in admin/modules, the theme selector works in admin/modules, major taxonomy fixup. removed the stars from login block.

More fixes to come: block and comment must use _execute format, because now filter_form in singleton format is a value.

chx’s picture

chx commented
Status: Reviewed & tested by the community » Fixed
pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
Status: Fixed » Needs review

Wasn't sure whether to re-open this one or not, but there's a mistake in that patch, I think. Just some missing inverted commas in taxonomy.module, tho. Attached patch fixes this after the above patch is applied.

chx’s picture

chx commented
Title: Another forms api patch » Apostrophes missing in taxonomy
Assigned: vertice@www.drop.org » chx
Category: task » bug
Status: Needs review » Active
pfaocle’s picture

pfaocle
He/Him
Primary language English
commented
Status: Active » Reviewed & tested by the community
StatusFileSize
new formapi_minor_fix_r2.patch2.53 KB

Another one in menu.inc. Updated patch attached.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)