Closed (works as designed)
Project:
Coder
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
21 Nov 2008 at 22:04 UTC
Updated:
3 Jun 2016 at 17:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
eMPee584 commentedMhh, the function name changed, why? Shall i rebase the patch or do you have conflicting plans with that function?
Comment #2
eMPee584 commenteduhhm just to explain, this issue comes only up in a single of my file which is comment-wrapper.tpl.php. That uses an enclosing php if statement which surpresses all output if the comment count is zero. Anyways, i think i can live with it.
Comment #3
stella commentedI still want to investigate this further.
Comment #4
eMPee584 commentedwell if you really do care here's my template file, it really is just the default from the comment module with the additional surrounding if clause to surpress the header output if no comments are present...
Comment #5
barrapontoconfirm: indeed, it only warns on comment wrapper template. i'm using a zen sub theme.
Comment #6
douggreen commentedI would like more feedbqck from themers on this and preferably a link to drupal docs with the template exception.
Comment #7
anoopjohn commentedI can confirm that none of the templates in core themes in D7.x has an ending ?>.
I can however think of a scenario where this is going to happen. When a template file has a last line like
<?php print $content; ?>I see that some of the template files in core does indeed end like this eg: forum-topic-list.tpl.php
Running phpcs on the forum module in D7 however does not return this error on any of the template files.
Comment #8
klausiIn Coder 8.x-2.x we disable the sniff in ruleset.xml for *.tpl.php files, so this should work fine there. Please test again with Coder 8.x-2.x, which can also be used to check Drupal 7 code.