coder should not complain about closing php tag within template files
eMPee584 - November 21, 2008 - 22:04
| Project: | Coder |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
Well, template files usually do end with closing php tags. This patch makes the function skip files ending on '.tpl.php'.
| Attachment | Size |
|---|---|
| coder-do-not-complain-about-closing-php-tag-in-templates.patch | 548 bytes |
#1
Mhh, the function name changed, why? Shall i rebase the patch or do you have conflicting plans with that function?
#2
uhhm just to explain, this issue comes only up in a single of my file which is comment-wrapper.tpl.php. That uses an enclosing php if statement which surpresses all output if the comment count is zero. Anyways, i think i can live with it.
#3
I still want to investigate this further.
#4
well if you really do care here's my template file, it really is just the default from the comment module with the additional surrounding if clause to surpress the header output if no comments are present...