Closed (fixed)
Project:
NewsFlash
Version:
5.x-1.6
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
21 Nov 2008 at 22:06 UTC
Updated:
25 Apr 2012 at 01:08 UTC
Jump to comment: Most recent file
Comments
Comment #1
sveina commentedComment #2
andrewmacpherson commentedThis is a bug. I'm happy to say I've found the solution.
I noticed that some nodes did not have the "Submitted by" info, but others did. It wasn't dependent on the node's content type. I scratched my head for some time before noticing that the submission info was only displayed for nodes that had taxonomy terms assigned to them.
The bug is in Newsflash's
node.tpl.phpfile:The template checks for taxonomy terms, and if the node has some, then the terms and the submission info are displayed. Without terms, the submission info is not displayed.
To fix the problem, the submission info needs to be handled outside of this condition. Here is my suggestion to replace the above buggy code:
This bug affects both 5.x-1.6 and 6.x-1.6 versions of Newsflash.
Examining the code for Newsflash versions 5.x-1.2 and 5.x-1.3 assures me that those versions are unaffected; the bug was introduced with the 1.6 versions.
Comment #3
andrewmacpherson commentedAn alternative fix, if you don't fancy mucking around with patches, would be to substitute the
node.tpl.phpfrom version 5.x-1.3 for the buggy version from 5.x-1.6,Comment #4
Dave Hirschman commentedSubscribing
Comment #5
andrewmacpherson commentedMarking this as critical since it renders the submission info unusable for installations where the settings are otherwise correct, i.e. post info is enabled at admin/build/themes/settings.
Comment #6
andrewmacpherson commentedbetter version of the patch
Comment #7
kisugiai commentedclosed -- issue fixed for 2 weeks with no activity.
Comment #8
keypetery commentedPatch in #6 seems to have worked for me, even though I am using 6.x-1.6. Just implemented, so may find issues later.
Thx Andrew