overzealous file_check_directory for file_directory_path

I'm doing a fresh install. When I visit admin/settings, I'm informed that "directory files does not exist".

The first setting I try to change is the file system path, hoping this error will go away. It does not. And it never will, until I create the files directory that it is looking for. This is because the code in system_view_general (system.module) which creates the settings form always checks for directory variable_get('file_directory_path'), BEFORE changing that variable to my new setting.

It's worth noting that no settings on the entire form will be saved until the user addresses this problem (by creating files directory and making it writeable).

The same goes for the directory_temp variable a few lines later.

I did the following to fix the problem. Consider it a patch if you like. I changed:

$directory_path = variable_get('file_directory_path', 'files');

To this:

$directory_path = $_REQUEST['edit']['file_directory_path'] or $directory_path = variable_get('file_directory_path', 'files');

The effect being that if user has changed the setting in the form, the code works with the new setting and not the old.

This applies to the latest cvs version of drupal.