false positive in patch on final ?>
scor - November 22, 2008 - 17:37
| Project: | Coder |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
with the patch http://drupal.org/files/issues/rdfa_ns_registry-332980-17.patch
coder complains about several
Line 9: the final ?> should be omitted from all code files
although this line is not in the patch.
The issue #337562: coder should not complain about closing php tag within template files seems to be related but since the patch above does not include the final ?> I'm filing it in a separate issue.
#1
This is a duplicate of #337562: coder should not complain about closing php tag within template files actually.
That message is appearing for a patch hunk for the file "themes/bluemarine/page.tpl.php". The coder patch reviewer functionality reviews both added lines (starting with +) and lines which have not changed. The last line in that patch hunk ends with a
?>and therefore is the same issue as described in #337562.Cheers,
Stella
#2
actually it's not a duplicate, because the last line of the patch hunk may not be the last line of the file. This review will need to be excluded for patch files.