Posted by seaji on November 22, 2008 at 8:08pm
Jump to:
| Project: | Upload previews |
| Version: | 5.x-1.2 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Line 93 should be:
$files[$id]['description']['#description'] = t('This file is not yet saved. The prospective URL will be <a href="@url">@url</a>', array('@url' => $url));Instead of:
$files[$id]['description']['#description'] = t('This file is not yet saved. The prospective URL will be <a href="@url">@url</a>.', array('@url' => $url));If you copy url, dot at the end of url is unexpected.
Comments
#1
Nope, this is intentional. Right-click on the link and select "Copy Location" or a similar menu item to copy the URL. The dot is outside of the
atag.#2
Yes, but this differ from the system upload module. There is not a dot in the system upload module. And users are used to select/copy/paste of url.
#3
I had many error reports from users about dot at the end of url.
#4
And if you do replacement of system module, you MUST copy system module as much as possible.
#5
Minor Issue I will make the change.
#6
Committed to Drupal-5 Branch of CVS. Looks like Head and Drupal 5 branch have been keep in sync.
Thanks
Robert
#7
Now the sentence is awkward. One sentence ends with a dot, but the second one doesn't. This could be resolved by changing the wording to "This file is not yet saved, but will be available at @url".
#8
KKaefer,
The wording makes since. Changed in CVS.
Thanks
Robert
#9
Automatically closed -- issue fixed for two weeks with no activity.