Line 93 should be:

$files[$id]['description']['#description'] = t('This file is not yet saved. The prospective URL will be <a href="@url">@url</a>', array('@url' => $url));

Instead of:

$files[$id]['description']['#description'] = t('This file is not yet saved. The prospective URL will be <a href="@url">@url</a>.', array('@url' => $url));

If you copy url, dot at the end of url is unexpected.

Comments

kkaefer’s picture

kkaefer commented
Status: Active » Closed (won't fix)

Nope, this is intentional. Right-click on the link and select "Copy Location" or a similar menu item to copy the URL. The dot is outside of the a tag.

seaji’s picture

seaji commented

Yes, but this differ from the system upload module. There is not a dot in the system upload module. And users are used to select/copy/paste of url.

seaji’s picture

seaji commented

I had many error reports from users about dot at the end of url.

seaji’s picture

seaji commented
Priority: Normal » Critical
Status: Closed (won't fix) » Needs work

And if you do replacement of system module, you MUST copy system module as much as possible.

rmiddle’s picture

rmiddle commented
Status: Needs work » Reviewed & tested by the community

Minor Issue I will make the change.

rmiddle’s picture

rmiddle commented
Status: Reviewed & tested by the community » Fixed

Committed to Drupal-5 Branch of CVS. Looks like Head and Drupal 5 branch have been keep in sync.

Thanks
Robert

kkaefer’s picture

kkaefer commented

Now the sentence is awkward. One sentence ends with a dot, but the second one doesn't. This could be resolved by changing the wording to "This file is not yet saved, but will be available at @url".

rmiddle’s picture

rmiddle commented

KKaefer,

The wording makes since. Changed in CVS.

Thanks
Robert

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.