Dot at the end of url

seaji - November 22, 2008 - 20:08
Project:Upload previews
Version:5.x-1.2
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

Line 93 should be:

$files[$id]['description']['#description'] = t('This file is not yet saved. The prospective URL will be <a href="@url">@url</a>', array('@url' => $url));

Instead of:

$files[$id]['description']['#description'] = t('This file is not yet saved. The prospective URL will be <a href="@url">@url</a>.', array('@url' => $url));

If you copy url, dot at the end of url is unexpected.

#1

kkaefer - November 23, 2008 - 00:09
Status:active» won't fix

Nope, this is intentional. Right-click on the link and select "Copy Location" or a similar menu item to copy the URL. The dot is outside of the a tag.

#2

seaji - November 28, 2008 - 14:27

Yes, but this differ from the system upload module. There is not a dot in the system upload module. And users are used to select/copy/paste of url.

#3

seaji - November 28, 2008 - 14:31

I had many error reports from users about dot at the end of url.

#4

seaji - November 28, 2008 - 14:35
Priority:normal» critical
Status:won't fix» needs work

And if you do replacement of system module, you MUST copy system module as much as possible.

#5

rmiddle - December 6, 2008 - 02:40
Status:needs work» reviewed & tested by the community

Minor Issue I will make the change.

#6

rmiddle - December 6, 2008 - 02:56
Status:reviewed & tested by the community» fixed

Committed to Drupal-5 Branch of CVS. Looks like Head and Drupal 5 branch have been keep in sync.

Thanks
Robert

#7

kkaefer - December 6, 2008 - 12:51

Now the sentence is awkward. One sentence ends with a dot, but the second one doesn't. This could be resolved by changing the wording to "This file is not yet saved, but will be available at @url".

#8

rmiddle - December 6, 2008 - 13:01

KKaefer,

The wording makes since. Changed in CVS.

Thanks
Robert

#9

System Message - December 20, 2008 - 13:05
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.