Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.i saw some errors in my watchdog like
Undefined index: draggable.png in /var/www/drupal-hfopi/sites/all/modules/contemplate/contemplate.module on line 57. and so on. While i was at it i also made the module pass all CODER tests.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | contemplate-cleanup.patch | 31.86 KB | eMPee584 |
| contemplate-bug-and-style-fix.patch | 11.9 KB | eMPee584 |
Comments
Comment #1
jrglasgow commentedeMPee584,
Great job with the patches. I appreciate the help. I just gave you commit access to Content Templates. Now you won't need me to commit the patches for you. Keep up the good work.
Comment #2
eMPee584 commentedaight cheers ;)
Comment #3
eMPee584 commentedmmh ok well i have access now but better ask if you're fine with this.. did some cleanups like indention fixes, shortening stuff and replacing double with single quotes where possible (performance!).. it's quite a lot though and changes ('improves') the menu items a bit. Commit?
Comment #4
jrglasgow commentedI guess the main question is this: does the module still work as expected? I don't have problems with changes made to bring it in compliance with the Code Review module.
There are just a few things I ask of you when making changes is this:
1 - Make sure you have good commit messages that describe briefly the changes, they don't hve to be exhaustive detail but they should be there.
2 - Commit early and commit often
3 - Give me let me know when you think we should do a next release. Now that I have someone helping me I will do the same.
Comment #5
eMPee584 commentedSir Yes, Sir!
and btw, i do any module development live onsite (http://hfopi.org) so i'm pretty sure it still works ;)
i'll still have to figure out though how to actually put my CVS account to good use but i guess that's the easier part of it.
Comment #6
eMPee584 commenteduhmm yeah i think this can be closed as i have committed the fixes and you fixed them ;)
thx for CVS access btw!