CCK amazon field says that Amazon ID 1591840562 cannot be found but it is retrieved and put in the database [#338097]

Steps to reproduce

1. Add a Amazon CCK field to content type
2. Make new content of that content type and fill in 1591840562 for the Amazon ID
3. Submit
4. A message will show up: "No Amazon product with the ID 1591840562 could be located."

Check the contents of the mysql database and the content for id 1591840562 is present. Furthermore the test

Furthermore if you go to
admin/settings/amazon/test
and fill in 1591840562 as the ID it works fine.

The error popups in asin.module

      foreach ($items as $delta => $item) {
        if (is_array($item)) {
          if (!empty($item['asin']) && empty($results[$item['asin']])) {
            form_set_error($field['field_name'] .']['. $delta .'][asin', t('%name : No Amazon product with the ID %id could be located.', array('%name' => t($field['widget']['label']), '%id' => $item['asin'])));
          }
        }
      }

I think empty($results[$item['asin']]) is not correct and should be empty($results[$delta]['asin']). In that case I don't get the error message but the amazon data doesn't show up

Comment	File	Size	Author
#8	amazon.array_merge.patch	725 bytes	Robrecht Jacques
#3	amazon.zip	5.62 KB	Arinaya

Comments

Comment #1

najibx commented 1 December 2008 at 17:57

what's the different Amazon CCK item - Text Field and Lookup by Title?

when using admin/settings/amazon/test,
it shows the actual books, and array. I will then use the field of that array to create my field, field_AMAZON_FIELD
For example i use the field "asin" (which become field_asin CCK field ) for the ISBN.

but always getting ISBN : No Amazon product with the ID 1584794747 could be located.

Another question is, what happen for books not listed in Amazon? So I shall have 2 ISBN type?

Comment #2

amccann commented 5 December 2008 at 22:04

I'm seeing the same thing but it is inconsistent - some products work, some don't.

Comment #3

Arinaya commented 27 December 2008 at 04:54

Status:

Active

» Needs review

Status	File	Size
new	amazon.zip	5.62 KB

Ok, I was running into the same bug, so here is a fix.

This seems to affect any book whose ISBN begins with '1'. When adding these ISBNs as an array key, PHP automatically converts it to an integer, even though it was a string to start with. Then, when array_merge() is called at the end of amazon_item_lookup(), the ISBN is lost entirely (array_merge() sees a numeric index, and so resets it to 0, as far as I can tell).

So I replaced the call to array_merge() with a for loop that takes care of merging the two arrays. This seems to fix the issue, at least for the cases I have tested.

In other words, I replaced

return array_merge($items, $items_from_web);

with this:

  foreach($items_from_web as $delta => $item) {
      $items[$delta] = $item;
  }
  return $items;

Sorry, I don't know how we're supposed to submit code changes, I am attaching an updated amazon.module file as a .zip

Edit: the attached amazon.module is from 6.x-1.0-beta5, so if you're running a different version you may just want to copy-paste the above lines into the end of amazon_item_lookup().