Inline-style color in rbg() format not working

kroimon - November 23, 2008 - 21:38
Project:WYSIWYG Filter
Version:6.x-1.0
Component:Code
Category:bug report
Priority:normal
Assigned:kroimon
Status:closed
Description

Hi!
Found a bug in your color-regex code.
wysiwyg_filter.module line 246 has to be changed from

<?php
  $regexp_color
= '#[a-fA-F0-9]{3}|#[a-fA-F0-9]{6}|rgb\(?:\s*[0-9]{0,3}%?(?:\s*,\s*[0-9]{0,3}%?){2}\s*\)|[a-zA-Z]+';
?>

to
<?php
  $regexp_color
= '#[a-fA-F0-9]{3}|#[a-fA-F0-9]{6}|rgb\(\s*[0-9]{0,3}%?(?:\s*,\s*[0-9]{0,3}%?){2}\s*\)|[a-zA-Z]+';
?>

There simply is a "?:" too much.

Without this fix, the color selector of FCKeditor won't work as it uses the rgb(rrr,ggg,bbb) syntax.

BTW: great plugin! thank you!

#1

markus_petrux - November 23, 2008 - 22:20
Status:needs review» fixed

Good catch, thank you! :)

Fixed in CVS. Release 6.x-1.1 is on the go...

#2

markus_petrux - November 23, 2008 - 22:21
Status:fixed» closed
 
 

Drupal is a registered trademark of Dries Buytaert.