Cleaning-up DrupalWebTestCase: pass #1
Damien Tournoud - November 24, 2008 - 01:00
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | simpletest.module |
| Category: | task |
| Priority: | critical |
| Assigned: | Damien Tournoud |
| Status: | closed |
Description
DrupalWebTestCase need a full cleanup, let's start by documenting class members, and adding proper visibility modifiers.
#1
A first pass of clean-up. This is likely to break some stuff around.
#2
#3
Unbreak Simpletest self-test.
#4
The last submitted patch failed testing.
#5
Fix session tests, and reroll for this night changes. Looks good to go for this first pass.
#6
So everything in here is just code comments, and private/protected corrections. Comments look fine to me, private/protected etc. also looks fine, but then with that stuff I'd probably not notice if it wasn't.
#7
About visibility modifiers: basically all methods are protected, except assert() that is very private and a public command: run().
#8
That explanation makes sense, so I'm marking to RTBC.
#9
Rerolled, and adding a fix for DatabaseTemporaryQueryTestCase that the test bot apparently missed. Also cleaned-up DrupalHTTPRequestTestCase that had a reference to ->_content in its comments.
#10
Committed to CVS HEAD.
#11
This broke the File > File scan directory test. Fix attached.
#12
+1 for #11
#13
Pump it to critical since it break simpletest.
#14
Thanks, committed. :( Really wish testing bot was catching these... :(
#15
Automatically closed -- issue fixed for two weeks with no activity.