Posted by Bevan on November 24, 2008 at 4:07am
3 followers
| Project: | Vertical Tabs |
| Version: | 6.x-1.x-dev |
| Component: | User interface |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Vertical Tabs module is not color.module compatible. See the screenshot of the module on drupal.geek.nz (Garland theme, Belgian Chocolate color set).
Separate the CSS into core-worthy (generic, grey) and theme-worthy (colored blue, for garland). Later we'll need to add the theme CSS to each and every core theme and tweak the colors to fit the particular theme or be color.module-compatible in the case of Garland. This is approximately equivalant or duplicate of an issue on nodeform's issue queue.
This has been forked off of #297944: Colorable CSS Illegal offset, Buttons not findable.
Comments
#1
I'll move this to features. Yes it's not pretty the way things are now, but theming is an inevitable part of building a real site. Color.module isn't real flexible at this point, but we'll see what sort of things might be possible to make Vertical tabs work with it. Otherwise we might need to simply remove all the "pretty" theming and make our own CSS that isn't theme specific.
#2
I've removed all the theme-specific code from Vertical Tabs, so it'll no longer look "blue" even if your theme is a different set of colors. Regarding the concerns in your screenshot, the use of vertical tabs on the general admin/settings/* pages has been entirely removed, which was more of an experiment than a practical application.
#3
I've committed the attached patch, which supports color module when used in combination with Garland. Potentially other themes could be supported, but they'd need to have the exact same default colors as Garland, which I think would be unlikely. As an alternative, I'd encourage the developer of the color-enabled theme to include Vertical Tabs CSS in their CSS file, then it's colors will be modified just the same as the rest of the theme.
#4
I created #354845: Left border below tabs missing which I think was introduced as part of this.
#5
Automatically closed -- issue fixed for two weeks with no activity.