Allow filtering of analysis results by SID

Thanks AsciiKewl. I think I'd be fine with this addition, though with a few minor changes. I'd prefer the $filter argument were an array, rather than just a string, it just seems a bit hackish tacking on a raw string at the end of the query. I guess at the same time, I don't know how we'd setup such an array that would allow the flexibility of the string.

Is there anything in particular that these results are being filtered by (UID, IP address, something else?) that we could make arguments directly?

I am planning on adding Views support to Webform (#273837: Views Integration for Webform), but I don't think this will be able to support the Analysis feature. Maybe it *could* if it were a very, very detailed implementation. But as-is, the analysis feature is too complicated to be included in the first-round of Views support (and it will only be for Drupal 6 anyway, since Views 1 doesn't support anything but nodes). I think for the time-being, I'd be satisfied with adding a $uid parameter alone. The addition of a free-form WHERE clause is too hackish for me and I think UID is about the only practical use-case currently. Implementing a variable array of clauses would basically be a whole query system that I don't think we need to create in Webform (especially since we have real query objects in D7, it'd just be wasted work). Plus, it'd also be a gateway patch to appease the users in #246371: Adding new permissions for accessing own webform results and deleting webform submissions. Do you think this would be an acceptable solution for you?

$filters['uids'] sounds good to me. It seems conceivable that $filters['nids'] or $filters['sids'] might be desirable later.

$filters = array(
  'uids' => array(1,2,3,4),
);

I was just thinking we'd need a single $uid value originally. But if you need multiple UIDs we can take this approach.

Nice, I like it. A much, much better solution to use SIDs rather than UIDs. The only change I think are minor code style changes:

Comments should be sentences:

+ * @param $sids
+ *   array of submission IDs (sid) to limit this analysis to
+ *   Optional

+ * @param $sids
+ *   Optional. An array of submission IDs (sid) to be included in this analysis.

Spacing issues:

+ $crows = $analysis_function($component,$sids);



+ $crows = $analysis_function($component, $sids);


And we should be using the secure way of writing "IN" statements using array_fill and creating placeholders. See an example in http://drupal.org/writing-secure-code

Hey AsciiKewl, I'd say "pretty good" chance. The 2.5 version needs to come out fairly quickly to fix a few bugs in the 2.4 release, and I think it'd be great to include this feature. Especially since it'd make #246371: Adding new permissions for accessing own webform results and deleting webform submissions possible at some later point. I'm getting busy again quickly, but I'll review this as soon as I can.

Thanks AsciiKewl, you're a champ for rerolling and sticking with my absences. Committed to both 5 and 6 branches. You rock, thanks for the patches. :)