According to #371: resolve ANSI SQL-92/99/2003 reserved words conflict in query statements founding, CVS HEAD schema is conflict with Oracle, e.g. 'uid' and 'access'. This patch target to replace these reserved words as 'userid' and 'lastaccess' (Moodle style).

Patch pass all normal simpletest; BTW, as 'uid' and 'access' is used within session.inc and both update.php, update path need some special exception handling and it is now buggy. May someone give a hand for that?

CommentFileSizeAuthor
dbtng-userid-lastaccess-1227520933.patch219.98 KBhswong3i

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

chx’s picture

chx commented
Status: Needs work » Closed (won't fix)
catch’s picture

catch
he/him
Primary language English
commented

For reference, the first line changed in the patch is this:

-if (!empty($update_free_access) || $user->uid == 1) {
+if (!empty($update_free_access) || $user->userid == 1) {

This should be worked around in the oracle driver, so there's no need to break 90% of contrib modules in addition to making our code less elegant.