[Oracle] replace reserved word 'uid' and 'access'
hswong3i - November 24, 2008 - 10:10
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | base system |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | won't fix |
Jump to:
Description
According to #371: resolve ANSI SQL-92/99/2003 reserved words conflict in query statements founding, CVS HEAD schema is conflict with Oracle, e.g. 'uid' and 'access'. This patch target to replace these reserved words as 'userid' and 'lastaccess' (Moodle style).
Patch pass all normal simpletest; BTW, as 'uid' and 'access' is used within session.inc and both update.php, update path need some special exception handling and it is now buggy. May someone give a hand for that?
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| dbtng-userid-lastaccess-1227520933.patch | 219.98 KB | Idle | Failed: Invalid PHP syntax. | View details | Re-test |
#1
The last submitted patch failed testing.
#2
#3
For reference, the first line changed in the patch is this:
-if (!empty($update_free_access) || $user->uid == 1) {+if (!empty($update_free_access) || $user->userid == 1) {
This should be worked around in the oracle driver, so there's no need to break 90% of contrib modules in addition to making our code less elegant.