Remove implementation of... comments from setUp(), getInfo() or tearDown()

drewish - November 24, 2008 - 11:31
Project:Drupal
Version:7.x-dev
Component:tests
Category:task
Priority:normal
Assigned:Unassigned
Status:closed
Description

Over on #276280: Tests needed: file.inc it was pointed out that we no longer have the PHPDoc Implementation of... for setUp(), getInfo() or tearDown(). Here's a mega patch to remove them from all the tests.

AttachmentSizeStatusTest resultOperations
tests_no_impl_docs.patch43.92 KBIdlePassed: 7440 passes, 0 fails, 0 exceptionsView details | Re-test

#1

Damien Tournoud - November 24, 2008 - 11:49
Status:needs review» reviewed & tested by the community

This looks great. The rationale for this is that we adopted our Test writers guidelines, and the consensus was that overridden methods do not have to be documented.

#2

Dries - November 25, 2008 - 13:14
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks.

#3

System Message - December 9, 2008 - 13:21
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.