download feed option messing up form submission

Scott Reynolds - November 24, 2008 - 19:23
Project:SimpleFeed
Version:5.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active
Description

When download all items in the feed option is selected the blog fails to be assigned the pathauto url, content_type table fails to be updated and a bunch of other issues. This is because the function simplefeed_feed_refresh() does a drupal goto. This causes tons of issues for form submissions. I have added an extra param to that function that says redirect or no. But perhaps we should consider a menu callback like this:

<?php
function simplefeed_refresh_page($nid) {
 
simplefeed_feed_refresh($nid);
 
drupal_goto('node/' . $nid);
}
?>

This I think is better because it keeps simplefeed_feed_refresh as an api function (BIG ++) instead of using it as a page callback. See attached patch for the first, not so great solution

AttachmentSize
redirect.patch1.68 KB
 
 

Drupal is a registered trademark of Dries Buytaert.