Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I tried using the Views integration in gmap.module without using location module (it did not say location module is required), but there is a single promise of a TODO item of autodetecting "longitude" and "latitude" named fields, when location module is not available and the autodetection mode is chosen. The location module way does not work without location module and the other is not implemented. So either that autodetection would need some love, or if pointless, then the views integration should be moved to gmap_location module IMHO, since that requires location, so the dependency would be met. What do you think?
If you choose not to move the support to the submodule, I assume Views does not cache options forms, so you can display the location.module item dynamically only if location.module is available and enabled. If not, you could return the autodetection module only. I am up for doing a patch for that, if you happen to have time to work on the autodetection code :)
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | gmap_style_page.png | 183.75 KB | russbollesjr |
| #9 | FireShot capture #5 - 'Edit view planting_map I' - www_norriscode_org_admin_build_views_edit_planting_map.png | 183.75 KB | russbollesjr |
| #2 | gmap_338587.patch | 7.19 KB | drewish |
| GMapLocation.jpg | 164.07 KB | gábor hojtsy |
Comments
Comment #1
gábor hojtsy@bdragon: What do you think would be the best way to go forward?
Comment #2
drewish commentedThe attached patch updates the views support to use version 2 of the API and lets you specify fields to use for latitude and longitude.
Marked #338300: views with style "list" works, views with style "GMap" shows blank content in page as a duplicate of this.
Comment #3
yesct commentedThe duplicate was my issue... so I'm tagging along following this one too. Thanks. :)
Comment #4
sjf commentedJust tested this and it works perfectly - I can now use relationships with gmap. Many thanks for this!
Comment #5
gábor hojtsyCode looks good to me. Just two comments:
- It might make sense to reuse uses_fields() in place of the if() checking for the same.
- The added FIXME would be good to clean up, although it looks out of scope for this issue.
Since these are not significant issues, I am not moving back to needs work. Would love to see this improvement land.
Comment #6
davidhk commentedThe patch also works fine with 6.x-1.0.
Comment #7
bdragon commentedI did a lot of work on the gmap style plugin yesterday, most of the problems should now be solved.
Comment #8
Boletus commentedWhat do you recommend? Using the dev version or patch the Gmap 6.x-1.0 with http://drupal.org/node/352553 ?
I need the Marker action in Gmaps generated by views.
Thanks for a great module!
Comment #9
russbollesjr commentedThis doesnt seem to be working correctly for 6.x-1.1-rc1. As shown in the screen shot there are no options to choose for the lat and long fields. Any thoughts?
Comment #10
russbollesjr commentedLooks like my picture attachment didn't work for some reason. Trying again.
Comment #11
russbollesjr commentednever mind, found http://drupal.org/node/371134. Which fixed the problem.
Comment #12
EvanDonovan commentedDoes this still apply to 6.x-1.x-dev? Reopen if it does.
Comment #13
bdragon commentedI'm going to wontfix this because the gmap views display plugin is moving in the opposite direction -- less and less location specific.