Display locations as polygons on gmap views

Thank you for this addition. I have a 6.x site where displaying neighborhood boundaries would be very useful, so I would love to see this get to GMap 6.x.

Will this make it into the 5.x version of module? I'm eventually upgrading to Drupal 6, but in the meantime...

I noticed the following in the release notes:

• 1.0 references "Allow using references to styles in lines / polys."
• "Document extramarkerevents and the new clickableshapes behavior flags. Add shape clickability."

Does this mean shape/polygon support is forthcoming?

Changed to "needs work" status since this probably needs to go into 6.x first, so existing patch needs modification.

Changing status as per #5.

(adding tag)

tagging

Has this progressed any?

Not sure what to make of this:

$ patch gmap_plugin_style_gmap.inc gmap_views_polygons_6x-1x.patch
patching file gmap_plugin_style_gmap.inc
patching file gmap.views_default.inc
can't find file to patch at input line 470
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|diff -rupN gmap_old/js/gmap_shapes.js gmap/js/gmap_shapes.js
|--- gmap_old/js/gmap_shapes.js 2009-04-07 07:23:17.000000000 +1000
|+++ js/gmap_shapes.js  2009-06-04 12:12:02.000000000 +1000
--------------------------
File to patch: gmap_shapes.js
gmap_shapes.js: No such file or directory
Skip this patch? [y] n

I guess it's looking for gmap_old/js/gmap_shapes.js? The file appears to be at js/gmap_shapes.js, so maybe the gmap_old threw it off? Or maybe my lack of knowledge of this system is throwing me for a loop. ;-)

I've applied this patch at -p 0, together with http://drupal.org/node/434290 and http://drupal.org/node/338745 and they work flawlessly. These guys also have a nice demo site on http://demo.agileware.net/ anyone can access and play around. I think these patches should be added to the GMap and Location modules HEAD. Great work!

Just posting using [#nnnnnn] notation
#434290: Multiple locations on a single gmap
#338745: Multiple locations on a single map

Small errors: on the Polygon grouping dropdown, there is a period at the end of each selection, and you used it's (contraction of "it is") where you probably meant its (possessive).

Bigger problems:

"Items to display" doesn't work right. It regulates the number of points, not the number of polygons. Suppose you have 2 nodes, the first node has 14 points, and the "Items to display" is left at the default value of 10. All the map shows is the first 10 points of the 14-sided polygon. This field only has meaning if set to Unlimited.

Polygons get merged. My view has two nodes displaying. All points get merged into one polygon, and if I click on the polygon, I get the information for the second node.

No way to select color. Without this, it's difficult to distinguish between nodes.

This patch is really exciting and I hope it eventually makes its way into the module. Since I have this working now in my test environment, I am more easily able to help with further testing.

Tag is missing a comma.

adding back tag (see location module faq issue which lists common location tags). Tag makes more sense when searching across multiple projects. http://drupal.org/project/issues/search?text=&projects=&assigned=&submit...

subscribing

Subscribing

Subscribing

Subscribing

sorry, but for the v5.x-1.1-rc1 patch I've got the issue similar to this one (http://drupal.org/node/303066) - "Fatal error: Call to undefined function update_sql()"

How to avoid it?

thnx

-v

I have done a lot of work on this (I work for Justin) and there is not really any free time for us to be working on this at the moment so I will do it in my own time.

I hope to get to it pretty soon and fix up a few more details.

Thank you. I look forward to these enhancements!

subscribing

subscribing

subscribing...

subscribing... also willing to co-finance the development, I need polygons !

Hello,
I am not really sure what I am doing wrong. I have downloaded the patch (gmap_views_polyons.patch) from the top of this page. I have run the following 'patch -p0 < gmap_views_polyons.patch'. I get the following message:

$ patch -p0 < gmap_views_polyons.patch
patching file gmap.install
Hunk #1 succeeded at 85 with fuzz 1 (offset 9 lines).
patching file gmap.module
Hunk #1 succeeded at 41 (offset 6 lines).
Hunk #2 succeeded at 134 with fuzz 2 (offset 35 lines).
Hunk #3 succeeded at 578 (offset -278 lines).
Hunk #4 succeeded at 634 (offset -278 lines).
Hunk #5 succeeded at 725 (offset -277 lines).
can't find file to patch at input line 96
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -rupN gmap_current/gmap_views.module gmap_new/gmap_views.module
|--- gmap_current/gmap_views.module 2008-11-25 11:56:36.000000000 +1100
|+++ gmap_views.module 2008-11-25 11:57:45.000000000 +1100
--------------------------
File to patch:

What am I doing wrong? The gmap module does not have gmap_views.module file...

Thank you,
-A

Please do not change issue titles to meaningless things. This makes it hard for others to locate them and possibly causes others to report duplicates. The title is there to provide a short description of the whole issue and not to reflect problems of each post made.

...changing back as it was.

The patch from #19 was created a year ago. This makes it almost certain that it will not apply cleanly to latest versions. You'll need to either try to apply it manually or wait until somebody re-rolls the patch against the latest stable or dev version.

Looks like there is some need for this, I need it myself for my sales staff to setup territories. A couple things im trying to do is be able to handle areas or just the normal points to this end for one of the things I am doing is creating some new views handlers. Hopefully to the point that I can display several areas (polygons) on one map.

whats weird is that it looks like the current stable has some sort of poly handling built in, looking at the js files you have an experimental poly.js file. Has anyone used this as of yet?

Seems like there are some substantial changes from the views plugin that was in gmap a year ago and the one in the stable now. SO there will be some research needed for that.

There have been a few things committed recently which means the patches don't apply properly.

There are more commits to come so at some point I will re-roll the patches.

If anyone wants to re-roll them in the meantime feel free.

Hello, the patch given in #19, as well as the one in #434290: Multiple locations on a single gmap fail with the current 6-dev version. Has anyone been working on an update on these patches?

I have got the gmap mod working, but when I load the page inside a fancybox the map does not work, it tries to reload the page but just displays a white page?

I can not see what is going wrong. Does anyone here have any insight or can help?

@zeezack: once again you hijacked an issue for a personal support request and assigned yourself to the issue. Please try to refrain from doing so. Start your own issues and assign yourself to them only if you are prepared to work on them.

This time you've also set its priority to 'critical'. Please see the links bellow the 'Priority' and 'Status' drop-down boxes and you'll find for yourself that ...the more-urgent priority is unlikely to give you better support

Please have a look here on how to report issues: http://drupal.org/node/73179

thanx

Here's a re-roll against gmap 6.x-1.1 that applies without failing
still testing

Patch at 47 works with gmap 6.x-1.1 and location 6.x-3.1 and patches found here #338745: Multiple locations on a single map and here #434290: Multiple locations on a single gmap (these aren't needed but make the node entry form a lot nicer)

Note that the changes at comment 2 didn't interact well with vertical-tabs module for some reason on FF3.6.

Thanks for the re-roll and testing, I forgot I'd only done the single map ones.
I'll spend some time on these on the weekend.

No worries, now working on getting polygon on node view too for multiple locations (without views), theme_gmap is so powerful!.

I am also interested to see how your doing on this patch. Looking for a way to add polygons to gmaps with locations.

hello,

I can see where this addition would be very helpful if you want to display a polygon on a view that is made up of DIFFERENT nodes. But what if all my points are on the same node, Would this still work for me? I installed the patch and noticed this is the way it is working. Is that correct?

Here is my use case:

I have a custom content type called neighborhood. Each neighborhood has 1 map, that has a polygon drawn on it which represents the neighborhood boundry. I will not ever need the polygon to be created from points from multiple or different nodes. They will always come from the same node.

In fact, in the simplest form what would work perfect for my situation is to duplicate the build a gmap macro page found at: map/macro. See attached screenshot.

I want the user to be able to draw the polygon directly on the map, like they can do on the build a gmap macro page. The other posts I have seen so far require Locations fields be set up. I don't necessarily need (or want) individual locations setup. I just want to mirror build a gmap macro exactly.

Is there a way to do this without alot of custom coding?

Thanks in advance for your help!

At this stage what this does is a polygon per node.

So each node has three or more markers on it and when using this patch you can make your view display the markers as a polygon instead of markers. So you will get one polygon per node.
That's pretty much the only way it works at this stage.

And the other patches for multiple locations on a single gmap just help make it easier to place the multiple markers that make up the vertices of the polygon.

None of the patches relating to this issue or the multiple location on a single map cover your use case of drawing polygons on the location selection map. That would be a new feature request, which would require work on the location & gmap modules.
It would probably be best as an extension of the multiple locations on a single map patches.
This is pretty much just a bit of thinking out loud at the moment though as I don't have time to get back to these patches and think about it properly until next week.

Thanks rooby for your feedback.

I found a solution that so far looks very promising so far. Open Layers is much more powerful then I had originally thought, and it draws polygons the way I want just as I wanted gmaps to do.

The demo that really helped me was this one: http://yadadrop.com/drupal-video/gis-mapping-drupal-openlayers-geo

Anyone else who needs to put polygons on maps might want to try this out. I'll post the final solution after I get it all working.

subscribing

[plus] : I'm looking for the same function, but with line.
Does someone knows if this patch could be a starting point for it ?

Regards

P-

...well a line is kinda polygon with no corners (only two points) ;)

So, I guess lines will be possible, but do you care to share with us why you need lines? I mean can you please give us a real life use case that utilizes lines?

Hi Klonos,

thanks for your reply.
In my case I want to use lines to visualy describe the itinerary of a node, from a location to another.
Like a gps tracker, but based on "human" adresses (location module) rather than gps datas (tracker module).

More generaly, I think it could be usefull for any kind of schematic itinerary and travel map (bird migration, flights, long distance travels, historical maps etc..).
What's your opinion on it ?

regards
-p

When I read your post in #56 I was left under the impression that you were after single, individual, two-point lines (a point for start and one for an end). You were talking about successive points forming a route though! I think this is a very nice feature request and that it deserves an issue of its own. Unless of course someone here thinks that it will be covered here. I am sure that this issue here will help people that need area data (like square units of the polygon for example), but I don't know for sure if it will do lines and distance units.

As stated in #54:

At this stage what this does is a polygon per node.

So each node has three or more markers on it...

So, the way I see it this works by setting *at least* 3 points and the first and last are joined to form a polygon. Lines should not behave this way (they can have only two points and their start & end don't necessarily get joined + they might be criss-crossed in different points). Anyways, the more suitable person to answer all these is Reuben of course, so...

@rooby: did you manage to find some time for this? Do you think that lines will/should be covered here or should we open a new issue for it?

Reroll incoming.

Here's a reroll with some changes:
-- Merged the common parts of the loop. (It's still too hard to read that function, though.)
-- Redid shape clicking in a more acceptable (not perfect yet though) way -- it supports all the stuff markers does. This part may go in separately since it's generally useful. (I am still trying to decide whether or not to set up default handlers for shapes like this, I might break existing code... If it does go in, it means the clickableshapes behavior should be removed. I might want to evaluate setting the overlay click handlers up on the map level though to reduce event overhead significantly first, though...)
-- Added rmt capability to match the general gmap views rmt capability I brought in earlier today.

I'm not really fond of this code, but then again I'm not fond of the render() in general for gmap_plugin_style_gmap().

hello all

just to know if you think i should open a new issue for lines, (#56 to #59) ?

I don't know if it can interest other people, but i hope so : i'm not able to solve that alone :)

Best regards
-P-

I guess it does make sense for ...say displaying bus routes and things like such. If you don't open a separate issue for it, I think I will.

here is the new issue :
Display lines between locations on gmap views / http://drupal.org/node/970724

Thanx von-p. Lets take it there then ;)

Subscribing

Subscribing

A newbie question: I have the latest version of gmap 6.x.1.1, and this feature doesn't seem to be available. I need to "Use polygon as points" in the style options of the view definition.

This patch seems to be for the dev version only, and we need to move forward. Can anyone help/offer advice? Am I missing something? Does the feature exist in the lasted version?

Failing that:

Our views module has been upgraded to 6.x-2.16, and our clickable polygones have stopped working with this error:
Notice: Undefined property: views_plugin_row_fields::$field_alias in views_plugin_row->render()

I really appreciate any help
thanks.

Since Multiple locations on a single map has been closed, I assume that both this patch as well as Multiple locations on a single Gmap are no longer being supported as they functionally rely on each other.

due to #69 - closed
feel free to open against latest major dev versions with ready to review patches

thanks to all