Link replacement expression is faulty

I'm guessing it's not img_assist, since with today's CVS version of print and Drupal 4.7, file attachments have the same open a tag.

This was my fix. I think this is probably a bug in core, but even if it gets fixed later, the str_replace should be harmless (unless for some reason people actually want <a <u> in their node).

<?php print str_replace('<a <u>', '<u>', $node->body); ?>

It's committed to CVS for Drupal 4.7 (but not tagged for 4.7 packaging). Needs backport for older versions.

On second review, I don't think a str_replace will do the whole job. Though I haven't verfied it, according to the preg_replace pattern in the source, <a target="_blank" href="... would produce <a target="_blank" <u> after replacement. It's probably going to need a fancier replacement expression or another one to cleanup after the first.

This appears to work as a new pattern for print_generate_node():

    $pattern = "@<a.*?href=([\']?[\"]?)([^\"|^\'|^|^>]*)([^>]*)>(.+?)</a>@ise";

This breaks the regex for properly counting URLs in HREF values, but I don't think I can really spend the time to make a regex to prevent it from breaking the link counter:

<a target="href=" href="http://test.com"style="border: 1px solid red">test</a>

I committed the <a.*? part of the pattern to replace the str_replace solution. I'll leave this open as a minor issue for figuring out the previous post's breakage example.

committed the <a.*? to DRUPAL-4-6

deekayen had mostly fixed the problem, but to solve the problem that he pointed out earlier, I re-wrote the tag parsing mechanism so that only href or src elements are handled. This is now in the latest 5.x dev release.