I thought Drupal might change link to "free public providers" in My Account from wiki to official website, which is listing providers in clean fashion and without any redundant information. Here's the patch to change it.
If it's possible, would be great to get it commited to both 6.x and 7.x :) Thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | getopenid-D6.patch | 2.3 KB | alexanderpas |
| #12 | openid-help-2.patch | 4.52 KB | c960657 |
| #2 | drupal_openid-prociders_user_friendly_link_try2.diff | 1.91 KB | patryk |
| drupal_openid-providers_user_friendly_link.diff | 1.82 KB | patryk |
Comments
Comment #2
patryk commentedPatch fixed.
Comment #3
patryk commentedComment #4
patryk commentedComment #5
patryk commentedAnyone could comment on this patch, and apply if possible? Thanks.
Comment #6
alexanderpas commentedmost trivial patch of the week...
Comment #7
patryk commentedCould someone commit this patch and we can continue to next challenges, please? :)
Comment #8
webchickThanks! Committed to HEAD.
Marking back to 6.x, as it looks like it'll apply there too.
Comment #9
patryk commentedThanks!
Comment #10
gábor hojtsyInteresting that the OpenID links wrap verbatim external links in url(), while the @handbook link does not. I don't think we have a practice of wrapping verbatim external links in url(), and it does not sound logical either. So let's first remove the url() wrappers from the verbatim links in openid_help() and then backport.
Comment #11
patryk commentedDo you have any specific recommendation on how should it be done? I might write a patch for that.
Comment #12
c960657 commentedThis patch removes url() around absolute URLs in openid_help().
Comment #14
c960657 commentedHEAD broke.
Comment #15
catchComment #16
webchickOh, good catch Gábor. Thanks!
Committed #12 to HEAD. Now this needs to be ported.
Comment #17
alexanderpas commentedported, including removal of
url()Comment #18
patryk commentedSeems good for me.
Comment #19
gábor hojtsyCommitted to Drupal 6 too, thanks.