Orphan fields in {content_group_fields} table when fields are removed [#339537]

Implementation of hook_content_fieldapi() in fieldgroup.module looks for 'delete', however the correct operation is 'delete instance'.

Attached patch fixes this, and also fixes the function comment from "Implementation of hook_fieldapi()" to "Implementation of hook_content_fieldapi()".

Comment	File	Size	Author
	fieldgroup.fieldapi.patch	525 bytes	markus_petrux

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

yched CreditAttribution: yched commented 2 December 2008 at 02:43

Status:

Needs review

» Fixed

Right - committed to 6.x-2.x (along with an update function to remove orphaned records).
Thx !

Comment #2

16 December 2008 at 03:01

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

Comment #3

markus_petrux CreditAttribution: markus_petrux commented 26 December 2008 at 10:22

Status:

Closed (fixed)

» Active

Reopening since the update function contains a little bug that cause an error when using table prefix.

The following SQL statement does not use table name delimiters for the table in the SELECT part:

  $ret[] = update_sql("DELETE FROM {content_group_fields} WHERE (field_name, type_name) NOT IN (SELECT field_name, type_name FROM content_node_field_instance)");

Instead, it should look like this:

  $ret[] = update_sql("DELETE FROM {content_group_fields} WHERE (field_name, type_name) NOT IN (SELECT field_name, type_name FROM {content_node_field_instance})");