In the biblio node view (when clicking on the title of the article), it is only hovered (module hovertips) the tagged link. The XML and Bibtex are normal links.

CommentFileSizeAuthor
#5 biblio_hover_export_links_v2.patch2.09 KBFrank Steiner
#1 biblio_hover_export_links.patch1.39 KBFrank Steiner

Comments

Frank Steiner’s picture

Frank Steiner commented
Status: Active » Needs review
StatusFileSize
new biblio_hover_export_links.patch1.39 KB

Just a blind shot because I don't have hovertips installed. Could you please test the patch?

setack’s picture

setack commented

Hmmm no, it doesn't. But maybe here is the problem. At arround line 299 (after the patch) in biblio_theme.inc there is something like:

'data' => $tagged_link .' '. l(t("XML"
), "$base/export/xml/$node->nid") .' '. l(t("BibTex"), "$base/export/bibtex/$node->nid")));

Here, $tagged_link was produced earlier with theme_biblio_tagged_link but the other two are simple links. Maybe you should call theme_biblio_xml_link and theme_biblio_bibtex_link as well.

rjerome’s picture

rjerome commented

I guess I forgot to mention when I pointed you to hovertips that it wasn't fully implemented on all the links yet, so what you are seeing is a known problem.

Ron.

setack’s picture

setack commented

ok thanks!

Frank Steiner’s picture

Frank Steiner commented
StatusFileSize
new biblio_hover_export_links_v2.patch2.09 KB

My patch did change to theme functions for bibtex and xml links, but I forgot to apply them. I might be fully misunderstanding how this hover stuff works, but with the new version of the patch I don't see any difference anymore between the links. Could you try the new patch?

setack’s picture

setack commented
Status: Needs review » Reviewed & tested by the community

right, this second version works. I tag the status of this patch to reviewed in case ron want to get it although it seems it is an already identified issue. Regards

rjerome’s picture

rjerome commented

Hi Guys,

I've taken a completely different (and what I think is a cleaner and more efficient) approach to the "popup" issue.

There is another module called "popups" which I've tested and it has a number of advantages over the hovertips module. One of the main ones is that each node doesn't have to be run through 3 export filters on every page load, it only goes through the export filter when the link is clicked. Also in my opinion, it looks considerably cooler :-) Lastly, I can see many other potential uses for this module, since you can popup virtually any form, make modifications and save it without reloading the current page.

Ron.

setack’s picture

setack commented

niceee, much better :-) Just one thing, the size of the popup should be adjusted to the text included in it. Anyway, much cooler than hovering.

rjerome’s picture

rjerome commented

By size, I assume you mean width? The problem there is that it could be much wider than the browser window. There is a scroll bar at the bottom which allows you to scroll to the right if needed. Ideally, I guess the content could be reformatted to fit with the size of the popup but that might cause other problems given some of the limitations of the export formats.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Closed (outdated)

This version is no longer maintained. If this issue is still relevant to the Drupal 7 version, please re-open and provide details.