Closed (won't fix)
Project:
Ubercart
Version:
6.x-2.x-dev
Component:
User Interface
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 Nov 2008 at 13:11 UTC
Updated:
9 Sep 2012 at 01:10 UTC
Hi,
Today, I wanted to theme the address selection system, and I noticed that the throbber animation for ajax loading is hard coded in uc_country_select.js file.
I think it's better to use display CSS property instead of directly put the background image, it would allow developper to theme the throbber.gif animation, for the case, like me, where the background is dark and need another throbber.gif file.
This patch add a display:block property when country is selected, so you can define the throbber gif to load in the CSS, and so, it's overwritable by custom CSS.
you have to add a CSS rule to uc_store.css too :
.zone-throbber { display:none; background:url(../../../../../misc/throbber.gif) no-repeat 0px -18px; }
| Comment | File | Size | Author |
|---|---|---|---|
| uc_country_select.js_.patch | 783 bytes | zmove |
Comments
Comment #1
rszrama commentedThe problem is we can't trust a single relative link to work across all sites. While ../../../../../etc. might work on one, it's bound to break for someone else.
Comment #2
tr commentedTagging
Comment #3
longwaveNot needed in 7.x but we could still change this in 6.x.
Comment #4
tr commentedIf someone wants to work on this and submit a patch, we can include it in Ubercart.
Comment #5
tr commentedWe're not going to change this in Ubercart 6.x-2.x at this point, and this does not need to be done in Ubercart 7.x-3.x because the throbber is displayed through the Drupal core Ajax support, which can be customized.