Hi,

Today, I wanted to theme the address selection system, and I noticed that the throbber animation for ajax loading is hard coded in uc_country_select.js file.

I think it's better to use display CSS property instead of directly put the background image, it would allow developper to theme the throbber.gif animation, for the case, like me, where the background is dark and need another throbber.gif file.

This patch add a display:block property when country is selected, so you can define the throbber gif to load in the CSS, and so, it's overwritable by custom CSS.

you have to add a CSS rule to uc_store.css too :

 .zone-throbber { display:none; background:url(../../../../../misc/throbber.gif) no-repeat 0px -18px; }
CommentFileSizeAuthor
uc_country_select.js_.patch783 byteszmove

Comments

rszrama’s picture

Version: 6.x-2.x-dev » 6.x-2.0-beta1
Status: Needs review » Needs work

The problem is we can't trust a single relative link to work across all sites. While ../../../../../etc. might work on one, it's bound to break for someone else.

tr’s picture

Issue tags: +Ubercart theme layer

Tagging

longwave’s picture

Version: 6.x-2.0-beta1 » 6.x-2.x-dev
Component: Code » User Interface
Category: support » task

Not needed in 7.x but we could still change this in 6.x.

tr’s picture

Status: Needs work » Postponed

If someone wants to work on this and submit a patch, we can include it in Ubercart.

tr’s picture

Status: Postponed » Closed (won't fix)

We're not going to change this in Ubercart 6.x-2.x at this point, and this does not need to be done in Ubercart 7.x-3.x because the throbber is displayed through the Drupal core Ajax support, which can be customized.