in form.inc, _form_get_error was replaced with form_get_error.

_form_get_error should have been moved to legacy.inc, where it is still called.

CommentFileSizeAuthor
#1 legacy-form-error.patch606 byteswebchick

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
StatusFileSize
new legacy-form-error.patch606 bytes

Indeed. This seems to cause problems with any module using the old form_* functions (which is almost all non-core modules atm), so pretty important this gets fixed!

Here is a simple patch that just adds in the copy from common.inc before Oct. 7. That seemed to solve the immediate problems I was getting, though there also seem to be other functions missing which may have other effects elsewhere.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Active » Needs review

Changing status.

chx’s picture

chx commented
Status: Needs review » Closed (duplicate)

Remove legacy.inc http://drupal.org/node/33852 is the fix. Read that issue.

Dave Cohen’s picture

Dave Cohen commented

That's not the fix for me. I'm using legacy.inc!

I've got code from my 4.6.x modules that uses the old forms API. While yes, it would be nice to upgrade it all to the new API, that's not going to happen right away. So I need legacy.inc.

Dave Cohen’s picture

Dave Cohen commented
Status: Closed (duplicate) » Needs review

Changed status. Not a duplicate.

jvandyk’s picture

jvandyk commented

This patch is needed to make modules that have not had their forms rewritten work.

hunmonk’s picture

hunmonk commented

legacy.inc is broken in more ways than just this. we're working on the fix, with the intention of having the old forms mostly supported in 4.7. by 'mostly supported', i mean that there will still be some changes devs will need to make to continue to take advantage of legacy support, but they will be minor compared to a full forms upgrade.

please be aware that this is being done ONLY to give devs a proper amount of time to get their mods converted. the new api fixes security issues, so please convert! legacy support will be removed from HEAD some time after 4.7 is branched--which means no legacy support for 4.8...

chx’s picture

chx commented
Status: Needs review » Postponed
bdragon’s picture

bdragon commented
Version: x.y.z » 6.x-dev
Status: Postponed » Closed (won't fix)

Legacy is dead.