Posted by dmitrig01 on November 28, 2008 at 4:25am
5 followers
| Project: | Drupal core |
| Version: | 7.x-dev |
| Component: | simpletest.module |
| Category: | task |
| Priority: | normal |
| Assigned: | boombatower |
| Status: | closed (fixed) |
Issue Summary
It's just a simple code style fix.
I also removed some stupidity where it was setting $permisions to default to NULL, and then if it was null then set it to the default array. Since there are no additional parameters, this is pointless.
Also, checkPermissions becomes private simply because it doesn't need to be protected (no one should use it).
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| private_permissions_simpletest.patch | 1.92 KB | Idle | Failed: 7386 passes, 0 fails, 56 exceptions | View details |
Comments
#1
The last submitted patch failed testing.
#2
The permissions need to be defined on drupalCreateUser() then, you can't just move the default in drupalCreateRole()...which is why the tests failed.
#3
#4
Also see #300993: User roles and permissions API.
#5
Read through code, looks good, bot passes.
#6
Committed to CVS HEAD. Thanks.
#7
Automatically closed -- issue fixed for 2 weeks with no activity.