It's just a simple code style fix.
I also removed some stupidity where it was setting $permisions to default to NULL, and then if it was null then set it to the default array. Since there are no additional parameters, this is pointless.
Also, checkPermissions becomes private simply because it doesn't need to be protected (no one should use it).

CommentFileSizeAuthor
#2 340081-drupalCreateUser.patch1.46 KBboombatower
private_permissions_simpletest.patch1.92 KBdmitrig01

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

boombatower’s picture

boombatower commented
Title: Remove the initial _ in the function name of drupalCreateRole in drupal_web_test_case.php » SimpleTest: Clean-up drupalCreateUser()
Assigned: dmitrig01 » boombatower
Status: Needs work » Needs review
StatusFileSize
new 340081-drupalCreateUser.patch1.46 KB

The permissions need to be defined on drupalCreateUser() then, you can't just move the default in drupalCreateRole()...which is why the tests failed.

boombatower’s picture

boombatower commented
Priority: Minor » Normal
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Also see #300993: User roles and permissions API.

dmitrig01’s picture

dmitrig01 commented
Status: Needs review » Reviewed & tested by the community

Read through code, looks good, bot passes.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.