The export form appears to not do anything when the "export" button is clicked. This is because the form is redirecting after being submitted.

Also, in the exported text, the first commented line "#String overrides export" does not have a line break after it.

Patch attached. Thanks for the module! ;)

CommentFileSizeAuthor
#1 stringoverrides-exportfix-340200-0.patch1.04 KBMark Theunissen

Comments

Mark Theunissen’s picture

Mark Theunissen commented
StatusFileSize
new stringoverrides-exportfix-340200-0.patch1.04 KB
robloach’s picture

robloach
he/him
commented
Version: 6.x-1.7 » 6.x-1.x-dev
Status: Needs review » Fixed

Thanks! Committed...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

davea’s picture

davea commented
Assigned: Mark Theunissen » Unassigned
Status: Closed (fixed) » Active

Hello Rob,

I am reopening this issue as it still seems to be occuring.

By adding an "exit", after the echo $export, it seems to be working again.

function stringoverrides_admin_export_submit($form, &$form_state) {
  drupal_set_header('Content-Type: text/plain');
  drupal_set_header('Content-Disposition: attachment; filename: "stringoverrides.po"');
  $export = stringoverrides_admin_export_text($form_state['values']['lang']);
  drupal_set_header('Content-Length: '. strlen($export));
  echo $export;
  exit;
  # $form_state['redirect'] = FALSE;
}

Also, the last line where $form_state is set, is no longer needed.

Thanks,
Dave

robloach’s picture

robloach
he/him
commented
Status: Active » Fixed

Thanks!
http://drupal.org/cvs?commit=410772

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.