Integer fields should be saved as integer rather than sint by default I think, since we are not usually doing range queries, and since integer seems to have better performance.
http://www.nabble.com/Help-optimizing-td17037362.html#a17095631
Also, we should prefix cck field with an additioanl stirng, so we avoid name-space collisions with other modules that want to add dynamic fields.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | cck-fix-340222-8.patch | 1.8 KB | pwolanin |
| #7 | apachesolr_trimcck.patch | 654 bytes | aufumy |
| #5 | sint-cck-340222-5.patch | 7.22 KB | pwolanin |
| #4 | sint-cck-340222-3a.patch | 7.22 KB | pwolanin |
| #3 | sint-cck-340222-3.patch | 7.17 KB | pwolanin |
Comments
Comment #1
pwolanin commentedComment #2
pwolanin commenteddiscussing w/ Robert and Jacob - we could think about shortening the dynamic field patterns to be like
isf_*rather thanisfield*, but maybe the effort is not worth it. The only reason would be if we were hitting field-name size limits or query URL size limits.Jacob says that Jetty supports 4096 chars in a URL, so it seems unlikely that we'd get close to this - even 4x facets that were 50 chars each...
In fact Jacob says he'd almost rather see us expand the names to make for better DX - e.g. integer_sf* or even integer_single_f*
Comment #3
pwolanin commentedbetter patch - does some clean up around the get_cck_fields functionality.
Comment #4
pwolanin commentedslightly better- add a bool cast.
Comment #5
pwolanin commentednodeaccess* -> stored=="false" since this is only ever being used to filter.
Comment #6
pwolanin commentedcommitted to 6.x
Comment #7
aufumy commentedUpon indexing,
$node->$keylooking for 'cck_field_test' instead of 'field_test'. Addedltrim($key, 'cck_')Comment #8
pwolanin commentedah, good point - though maybe we should just construct this better - like this?
Comment #9
aufumy commentedIt works! Deleted index, ran cron and tested fine.
Thanks
Audrey
Comment #10
pwolanin commentedcommitted to 6.x
Comment #11
pwolanin commentedat some point all these changes need to be backported.
Comment #12
pwolanin commented