Dont write empty $database values to settings.php

Dave Reid - November 29, 2008 - 03:12
Project:Drupal
Version:7.x-dev
Component:install system
Category:task
Priority:normal
Assigned:Dave Reid
Status:won't fix
Description

If we don't write empty $database values to settings.php, we can actually use default connection options (like port numbers) in the database driver constructors. I tested this with all three: mysql, postgresql, sqlite!

AttachmentSize
database-construct-D7.patch3.22 KB
Testbed results
database-construct-D7.patchfailedFailed: Failed to apply patch. Detailed results

#1

System Message - November 30, 2008 - 03:55
Status:needs review» needs work

The last submitted patch failed testing.

#2

Dave Reid - December 3, 2008 - 15:44
Status:needs work» won't fix

We have worked around this by using !empty(...) in the database connection options. Marking as won't fix.

 
 

Drupal is a registered trademark of Dries Buytaert.