don't init db twice
justinrandell - November 29, 2008 - 11:30
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | base system |
| Category: | bug report |
| Priority: | critical |
| Assigned: | justinrandell |
| Status: | closed |
Jump to:
Description
very small patch from looking at drupal_install_system as part of #340052: speedup simpletest by preloading the registry.
* we call drupal_init_database twice for no apparent reason
* drupal_install_init_database has a static variable that appears to be guarding against running its body twice, but its not updated on the first run
attached patch fixes these issues.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| dont_init_db_twice.patch | 1.06 KB | Idle | Passed: 7423 passes, 0 fails, 0 exceptions | View details | Re-test |
#1
Installing works after this patch, let's hope the testbot is happy too :)
#2
Nice catch; this was completely silly.
Committed to HEAD.
#3
Automatically closed -- issue fixed for two weeks with no activity.