inline biblio_db_search layout is broken
deselaers - November 29, 2008 - 17:04
| Project: | Bibliography Module |
| Version: | 6.x-1.0-beta9 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Description
Hi,
I just upgraded to the beta9 release and noticed that the layout resulting from the following code is completely broken:
<?php
include_once drupal_get_path('module','biblio') . '/biblio.pages.inc';
print biblio_db_search("inline", "keyword","selected");
?>The broken page can be seen at http://thomas.deselaers.de/SelectedPublications
Any hints?
Thanks,
thomas
#1
It seems to be getting the data, but it looks like the layout is failing. Most likely css related?
#2
comment out line 3 of biblio.css and it will fix your probem.
Ron.
#3
done!
Solves the problem! And it also solves another bug I have reported some time ago on clicking onto nodes from that page. I will try to find it and close it.
Great to have you back.
Cheers,
thomas
#4
That was my fault, I added this for the search box. I will take a look.
#5
Yes, I didn't want to point fingers but... :-)
Why did you need that inlined?
#6
I'm not sure, I will have to look on Monday when I'm back in the office. The first version of the search patch was quite a while ago, at least two months before I started learning CSS, so at this time I didn't really know what I was doing with the CSS stuff :-) I think I wanted the search button next to the textfield, but I didn't know about floating at this time, so I tried around and with the inline property it suddenly worked -:-)
I'll fix this in a clean way :-)
#7
Great.
If there is something which needs testing, just let me know.
I might be a bit short in time on tuesday, but after that I should be able to test stuff pretty quickly.
cheers,
t.
#8
I see there are a few other issues with "inline" mode... clicking on an author or title on this page (http://thomas.deselaers.de/SelectedPublications) illustrates the problem.
I'll look into a solution.
Ron.
#9
Wow, the code for the search form was really messed up :-) I hadn't looked at it again since June. The attached patch removes a lot of unneccessary stuff from biblio_search_form(). There's no need for any additional css anymore, so I cleaned up biblio.css from all stuff that I added before for the search form. It shouldn't influence any biblio output anymore. Sorry for the trouble!
cu,
Frank
#10
#11
Committed to CVS
Ron
#12
Automatically closed -- issue fixed for two weeks with no activity.
#13
Hello,
I just noticed that the error described in #8 still exists (or came into existance again) with my biblio version 6.x - 1.2. If I click on a page with a link to /author/123/inline, the layout is really broken, exactly as on the webpage in #8.
Any ideas why?
Thanks,
Chris
#14
Hi Chris,
I never addressed that particular issue, but it's fixed now.
Ron.
#15
Hey Ron,
once again thanks for your quick support!! Do you already know when the release will be released?
Chris
#16
Not really, but maybe today if nothing else crops up.
Ron.
#17
Automatically closed -- issue fixed for 2 weeks with no activity.
#18
Hey Ron,
now the /author/123/viewinline link is working. However, if I use the function biblio_db_search('author', $cid, 'inline', 'year', $year) with this parameters, it fails. Seems like the 'inline' parameter is causing the problem and the error seems to be within the biblio_show_results function.
Best,
Chris