The table width problem described in case 337870 is because of line 116 of layout.css where #content gets width: 100%;.

There is also width: 100%; in line 164 of style.css, but commenting it out doesn't appear to have an effect.

Comments

aren cambre’s picture

Firebug says it's the stuff in style.css...

Jeff Burnz’s picture

Title: All tables being forced to 100% » All tables being forced to 100%
Category: bug » feature
Status: Active » Closed (fixed)

The node you cite says nothing about tables, its about nodes.

Can't see an issue here that's not already covered in the issue queue.

aren cambre’s picture

Title: All tables being forced to 100% » All tables being forced to 100% width
Category: feature » bug
Status: Closed (fixed) » Active

From his case:

Issue 4. I have on some nodes Tables most with set width etc., but now they are stretching to full width, breaking the node layout. It appears theme related, but as i am no expert, I tried changing the css, but without luck. Could you point me in the right direction.

He's talking about <tables> in nodes.

All tables are being stretched as if width=100%. This is undesirable behavior: many tables should not be stretched to the same width of its containing element.

Jeff Burnz’s picture

Category: bug » support

Then comment it out in the CSS is its "undesirable behaviour" for your site.

This is not a bug - its a design decision on my part - its dead easy to modify if you need to change it.

aren cambre’s picture

Category: support » feature

Thanks. I respect that it's your theme, but please realize that many tables make less sense at 100% width.

E.g., a simple table showing a list of positions in a club and the person filling the position. See attached.

aren cambre’s picture

Sorry, file didn't make it for some reason.

Jeff Burnz’s picture

Status: Active » Closed (won't fix)
#node-nid table {width: Npx;}

Or add a class to each table:

table.myclass {width: Npx;}
aren cambre’s picture

Status: Closed (won't fix) » Active

The problem is I can't "unset" the width: 100% and allow the table to auto-size with its contents. That's why I think this is a bug. It just doesn't make sense (to me) to arbitrarily change such a key measurement of all tables.

Jeff Burnz’s picture

Status: Active » Closed (works as designed)

*shrug*

Jeff Burnz’s picture

Status: Closed (works as designed) » Closed (fixed)
Jeff Burnz’s picture

You can unset it, as I already pointed to with the link, you can comment it out in the main style sheet, the two examples I give both have a higher specificity also.

To reiterate:

1) You have been given the fix for dealing with the issue - it is a simple and easy CSS change to the main stylesheet.

2) You were given a valid reason for maintaining the status quo - that this is my design decision. This is not a core theme, its a highly stylised contributed theme.

3) Your feature request was legitmatly denied. You have to live with that - that is my descison. I am not interested in discussing this further as indicated by the "won't fix".

If we as designers pander to every request, especially those citing reasons such as "I think it should be like this just because", then where would we be - design by committee? The design is compromised, and in essence lost.

I have asked for suggestions in the past, but none were suitable for inclusion in this theme. For some of my other themes I have immediatly implimented ideas contributed from the community - such as the additional regions in Newswire which were a great idea.

However, this is a design decision for PR - first made by Hideki, and seconded by myself. It looks good in the admin sections and IMO tables do look better when they fill the entire width.

Of the 1000+ websites using this theme (estimate, usage stats are broken right now), you are 1 of only 2 people to have an issue with this. That tells me by and large this design decision is not only acceptable, but liked by the vast majority of users.