Closed (fixed)
Project:
e-Commerce
Version:
5.x-3.0
Component:
cart
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
14 Oct 2005 at 17:14 UTC
Updated:
14 Jun 2007 at 06:51 UTC
Jump to comment: Most recent file
When I run extractor.php on cart.module,v 1.64 2005/10/08 22:05:06, I get this error:
Invalid marker content in cart.module:474
* format_plural($product->qty,t('1 order'),t('%count orders'))
What could be the problem?
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | ec-head-translation-fix_0_0.patch | 4.42 KB | syllance |
Comments
Comment #1
syllance commentedthe problem is that there's no need to call t() inside a format_plural() call, as t() is called by format_plural iself.
format_plural($product->qty,t('1 order'),t('%count orders')) should be
format_plural($product->qty,'%count order','%count orders')
note that this not the only issue with translation. i started a patch for these but i need to resync it with head. use this thread to post any other translation related issue you find, i'll then be able to check the one i missed, and will send the patch here once finished.
Comment #2
syllance commentedhere is a patch to fix various translation issues for head, including the one above in cart.module.
the patch is head port of http://drupal.org/node/31936.
Comment #3
fgmReclassified: uses the 4.6 API.
Comment #4
fgmIn addition, the issue remains present, at least for product.module/product_unit_nice_name, in the 4.7 version.
Patch should be updated for 4.7 by replacing the form_* calls by FAPI forms.
Comment #5
brmassa commentedComment #6
(not verified) commented