Project:Apache Solr Search Integration
Version:6.x-1.x-dev
Component:Code
Category:task
Priority:critical
Assigned:pwolanin
Status:closed (fixed)

Issue Summary

There is not need to request the luke info every time we do a search.

We should implement cache_set/get in Drupal_ApacheSolrPHPClient in getFields().

Comments

#1

Status:active» needs review
AttachmentSizeStatusTest resultOperations
cache-luke-341175-1.patch4.08 KBIgnored: Check issue status.NoneNone

#2

better- let's just clear the cache when we commit, since there's basically a 1-to-1 of when we commit and clear the cache.

AttachmentSizeStatusTest resultOperations
cache-luke-341175-2.patch2.27 KBIgnored: Check issue status.NoneNone

#3

Assigned to:JacobSingh» pwolanin

improved code comments

AttachmentSizeStatusTest resultOperations
cache-luke-341175-3.patch2.85 KBIgnored: Check issue status.NoneNone

#4

Assigned to:pwolanin» Anonymous
Status:needs review» reviewed & tested by the community

Reviewed. This looks great!

#5

Version:6.x-1.x-dev» 5.x-1.x-dev
Assigned to:Anonymous» pwolanin
Status:reviewed & tested by the community» patch (to be ported)

committed to 6.x

#6

Yeah, looks fine to me. I would make it go stale after some point. Perhaps just clearing on cron is good enough. I don't like the idea of not clearing unless there is a commit (but I'm not saying we have to change it now). There are two reasons:

1. There is another site updating the same index.
2. We may remove commits from the client side.

Best,
Jacob

#7

Status:patch (to be ported)» active

@Jacob - sure we could add clearing on every cron run too.

#8

Version:5.x-1.x-dev» 6.x-1.x-dev

#9

Status:active» patch (to be ported)

It appears this is already done.

#10

Version:6.x-1.x-dev» 5.x-1.x-dev

yes, I think 6.x is all done

#11

Version:5.x-1.x-dev» 6.x-1.x-dev
Status:patch (to be ported)» closed (fixed)