Cache Luke information on cron
JacobSingh - December 1, 2008 - 15:04
| Project: | Apache Solr Search Integration |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | critical |
| Assigned: | pwolanin |
| Status: | closed |
Description
There is not need to request the luke info every time we do a search.
We should implement cache_set/get in Drupal_ApacheSolrPHPClient in getFields().
#1
#2
better- let's just clear the cache when we commit, since there's basically a 1-to-1 of when we commit and clear the cache.
#3
improved code comments
#4
Reviewed. This looks great!
#5
committed to 6.x
#6
Yeah, looks fine to me. I would make it go stale after some point. Perhaps just clearing on cron is good enough. I don't like the idea of not clearing unless there is a commit (but I'm not saying we have to change it now). There are two reasons:
1. There is another site updating the same index.
2. We may remove commits from the client side.
Best,
Jacob
#7
@Jacob - sure we could add clearing on every cron run too.
#8
#9
It appears this is already done.
#10
yes, I think 6.x is all done
#11