Closed (fixed)
Project:
Apache Solr Search
Version:
6.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Task
Assigned:
Reporter:
Created:
1 Dec 2008 at 15:04 UTC
Updated:
18 Jan 2009 at 03:11 UTC
Jump to comment: Most recent file
There is not need to request the luke info every time we do a search.
We should implement cache_set/get in Drupal_ApacheSolrPHPClient in getFields().
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | cache-luke-341175-3.patch | 2.85 KB | pwolanin |
| #2 | cache-luke-341175-2.patch | 2.27 KB | pwolanin |
| #1 | cache-luke-341175-1.patch | 4.08 KB | pwolanin |
Comments
Comment #1
pwolanin commentedComment #2
pwolanin commentedbetter- let's just clear the cache when we commit, since there's basically a 1-to-1 of when we commit and clear the cache.
Comment #3
pwolanin commentedimproved code comments
Comment #4
paul.lovvik commentedReviewed. This looks great!
Comment #5
pwolanin commentedcommitted to 6.x
Comment #6
JacobSingh commentedYeah, looks fine to me. I would make it go stale after some point. Perhaps just clearing on cron is good enough. I don't like the idea of not clearing unless there is a commit (but I'm not saying we have to change it now). There are two reasons:
1. There is another site updating the same index.
2. We may remove commits from the client side.
Best,
Jacob
Comment #7
pwolanin commented@Jacob - sure we could add clearing on every cron run too.
Comment #8
pwolanin commentedComment #9
JacobSingh commentedIt appears this is already done.
Comment #10
pwolanin commentedyes, I think 6.x is all done
Comment #11
pwolanin commented