1) what are the differences between this and the version from Nov 8? i ran ExamDiff on the two modules that i am using (lm_paypal and lm_paypal_subscriptions) and saw no changes whatsoever. i guess i could compare all the other files too, i just thought i'd ask if the authors could give us a verbal description.

2) IMPORTANT! unless i've missed something somehow, both the Nov 8 and Nov 30 versions have a bug in them... did anyone try these and find that the notification emails upon new subscription (to admin AND to the user) were both BLANK in their subject and body? Well, after a bit of fiddling, i found out why... there's a mail handler hook that should be defined but wasn't, it had been removed, though it was in the original version i had (dated approx Oct 13, or maybe Oct 16)... you need to have function lm_paypal_mail, or you will get the blank emails! If you want to add it to your Nov 8 or 30th version right now and verify this, here's the function:

function lm_paypal_mail($key, &$message, $params) {
// TODO: stuff needs moving here from above function!
$language = $message['language'];
$subject = $params['subject'];
$body = $params['body'];
switch ($key) {
case 'notify':
$message['subject'] = $subject;
$message['body'] = $body;
break;
}
}

and a progress report... we have signed up approximately 300 users already using this code, and it's been working just fine! the ONLY real glitch (other than the missing function above :-)) in any of the original code is something that may not even be the fault of lm_paypal, but just a glitch in paypal processing period. i will post it to another thread as a separate issue, so as not to confuse it with this one.

thanks SO MUCH to LeeMcl and lyricnz (and any other coders involved) for their hard work on this! I am comfortable coding but knew nothing about paypal processing before this project started, this would have been MUCH harder without these fine modules available!

cheers
Fish
http://goatvirus.com

Comments

lyricnz’s picture

lyricnz commented
Status: Active » Fixed

1) You can view changes to the source on the CVS page. In this case, the recent change was to lm_paypal.install, which changed the width of the payment_date field from 20 to 28 characters (remember to run update.php!)

2) I can see the change that removed lm_paypal_mail(). That definately looks like (my) bug! I've reapplied a slightly updated version of that function. Please test!

Thanks for your compliments, and contribution. Perhaps you would like to contribute to #328730: Make it easier to integrate with LM Paypal?

earthangelconsulting’s picture

earthangelconsulting commented

lyricnz - thanks for the info (I think I was very tired when I posted that, I could have just checked the file mod dates to see which one changed! How silly of me), and the invite (very flattering!)... I am under tight deadlines right now but will contribute some comments (and maybe even some coding) to issue http://drupal.org/node/328730 as soon as I possibly can.

cheers
Fish

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.