Download & Extend
GMap Addons » Issues

Browser error on overlay

Posted by wessex on December 2, 2008 at 2:01pm
Project:GMap Addons
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Whenever I try to overlay data, I get the browser error "gmap-auto1-gmap0" - clicking OK to the error loads the map and overlay as expected.

Any ideas what could be up?

Login or register to post comments

Comments

#1

Posted by dziegel on December 14, 2008 at 4:18pm
Version:5.x-1.x-dev» 6.x-1.x-dev

Seems like debug code was checked in.

Edit the file js/overlay_geoxml.js so that the line

  alert (obj.map.getContainer().id);

reads

//  alert (obj.map.getContainer().id);

or remove the whole line entirely.

HTH,
dziegel

#2

Posted by wessex on January 5, 2009 at 1:21pm

Thanks dziegel, I'll give it a try!

#3

Posted by wessex on January 5, 2009 at 1:37pm

It worked!

Thanks ever so much :-)

#4

Posted by geodaniel on February 27, 2009 at 2:40pm
Status:active» needs review

Patch attached.

AttachmentSize
gmap_overlays_remove_alert.patch 685 bytes

#5

Posted by mcengland on October 14, 2009 at 5:55pm

--Ignore... found my error--

#6

Posted by seutje on March 29, 2010 at 2:43pm

things like this can be easily traced back to it's origin by overriding the window.alert function to something else, console.trace for instance (requires firebug or a console.trace compatible browser)

this isn't the prettiest, but it's an easy way to inject it before everything else from within a theme's template.php:

<?php
function mytheme_preprocess_page(&$vars) {
  $vars['scripts'] = '<script type="text/javascript">window.alert = function(msg) { if (console) { console.trace(msg); } };</script>' . $vars['scripts'];
}
?>

#7

Posted by kbk on September 15, 2010 at 3:28pm
Component:Miscellaneous» Code
Status:needs review» reviewed & tested by the community

#4 Works for me. Can this be committed?

#8

Posted by garbo on January 12, 2011 at 10:15am

I had this error too and commenting out the line as noted at #4 worked.

But why is this alert in the code? This has been there apparently for a long time seing the postdate of this thread. Obviously the developers think it needs to be there but why?

#9

Posted by bdragon on January 26, 2011 at 1:55am
Status:reviewed & tested by the community» fixed

Actually, the problem is not that I think it needs to be there, it's that I'm doing so poorly at remembering to maintain gmap_addons that it really *has* accidentally been left in for two years.

Fixed, thanks, and sorry for the ridiculous wait.
http://drupal.org/cvs?commit=488992
http://drupal.org/cvs?commit=488994

#10

Posted by garbo on January 27, 2011 at 2:30pm

hi bdragon,

Thanks for your reply to this! I'm glad this issue is sorted out now. And thanks for the nice software!

#11

Posted by System Message on February 10, 2011 at 2:40pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.