This issue is related to http://drupal.org/node/341314 but I am opening a new issue because http://drupal.org/node/341314 is talking about an individuel display error and for me the module works afaik but I think the html output should be changed.

As modules should follow Drupal core they should produce valid html. Now I hope it is not the fault but I couldn't find any configeration options the change the output. This is the html I get:

<div class="content">
	<span style="width: 180px;" id="ssc-1" class="ssc">
		
		<a class="ssc-previous active" id="ssc-previous-1" href="/impressum?ssc=1,8">Previous</a> <span id="ssc-index-1" class="ssc-index">fade <span id="ssc-current-1" class="ssc-current">1</span>/8 </span><a class="ssc-next active" id="ssc-next-1" href="/impressum?ssc=1,2">nächste Seite</a>
	
		<span style="height: 630px; width: 180px;" class="ssc-content" id="ssc-content-1">
			
			<span style="height: 630px; width: 180px;" id="ssc-slide-1-0">
				<span class="ssc-title"/>
				<span class="ssc-description"/>
				<div class="ssc-main">
					<img title="" alt="" src src="http://mydomain.net/sites/default/files/slideshow/1.jpg"/>
				</div>
			</span>
			<span style="height: 630px; width: 180px;" id="ssc-slide-1-1">
				<span class="ssc-title"/>
				<span class="ssc-description"/>
				<div class="ssc-main">
					<img title="" alt="" src src="http://mydomain.net/sites/default/files/slideshow/2.jpg"/>
				</div>
			</span>
			...
		</span>
	</span>
</div>

Now the problem is, that a div shouldn't be inside a span. A span should not contain a block level element.
How about making #ssc-current-1, #ssc-1 and .ssc-content divs or making the whole thing a unordered list?

I think a unordered List would be the best option since that is what is ist.

Cheers Sebastian

Comments

jgrevich’s picture

jgrevich commented

Is anyone working on this? I agree with Sebastian on the use of an unordered list.

justin

s.daniel’s picture

s.daniel commented

I ended up using Views to generate a list in junction with manually adding innerfade jquery script via template.php.
http://medienfreunde.com/lab/innerfade/

drupal_add_js('sites/all/themes/zen/mytheme/js/jquery.innerfade.js');

 drupal_add_js (
    '$(document).ready(function(){$("ul#slideshow").innerfade({containerheight:"630px",speed:"2000",timeout:"4500"});}); ',
    'inline');
brmassa’s picture

brmassa commented
Status: Active » Closed (won't fix)

Guys, there is a drupal.org initiative about unifying some modules. Since Slideshow Creator is by far less powerful and flexible and other solutions, I will not support it more. Please, take a look on other similar modules.

snoopz1’s picture

snoopz1 commented
Status: Closed (won't fix) » Fixed

Change div to span
and it will fix "div shouldn't be inside a span. A span should not contain a block level element" problem
it will also pass check for "XHTML 1.0 strict" regulation ---> http://validator.w3.org/#validate_by_uri+with_options
example below

from

<div class="ssc-main">
<img title="" alt="" src src="http://mydomain.net/sites/default/files/slideshow/1.jpg"/>
</div>

to 

<span class="ssc-main">
<img title="" alt="" src src="http://mydomain.net/sites/default/files/slideshow/1.jpg"/>
</span>

How to do that ?
looking in file "slideshow_creator.inc"
line number : 342. '#main' => "<div class='ssc-main'>$main</div>\n",
change it to '#main' => "<span class='ssc-main'>$main</span>\n",

take a look on my website ซ่อมคอมพิวเตอร์ วัชรพล computer

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.