Posted by mikeytown2 on December 2, 2008 at 6:32pm
Jump to:
| Project: | PNG Behave! |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | support request |
| Priority: | normal |
| Assigned: | mrjeeves |
| Status: | closed (fixed) |
Issue Summary
How would I target that? Right now I can't get it to work on my png logo. Use to have pngfix enabled. Your demo site works, but my test site doesn't when using Multiple IE -> IE6. I only have one png file on the page. The style and script tags are loaded in the source near the top of the head tag.
This is my current selector
div h1 a imgI've also tried img, but it didn't work.
Comments
#1
Do you have a link i can view this issue at? I am unable to reproduce this issue. Also, remember to use commas in your selector string to select elements at a global scope. in other words, if you want all div, h1, a, and img, then you would need a selector like:
div, h1, a, imgBy the way, how does using 'div' work for you? I caused my pages to load much much slower and i'd love to hear some usage results
#2
Also, this link provides information suggesting that using Multiple IE is causing the conditional comments to fail. Let me know.
#3
Found a computer with the original IE6 in it and it still doesn't work. pngfix works, but it messes up the positioning; was hoping that this would work. Running 6.6 despite the name, and all the modules are updated to their latest version. Switched selector to
img.http://www.bluediamondhomeandrv.com/D6/drupal-6.4/
I made the base website about 2 years ago, and it needs to be updated; it's all php no sql, so the search function that I wrote in php is severely limited. Also updating the content wasn't exactly easy; that's why I picked drupal and that's why I'm here. I'm starting to get a handle on all the arrays and drupal syntax. Anyway let me know if you have any suggestions on the png issue.
#4
your issue was related to the install being in a sub directory. I have released version 1.1 with corrections for this instance.
Version 1.1 introduces bug fixes for relative sub directory installs. (i.e. www.mysite.com/mydrupalinstall/)
Replaced Line 21 in pngbehave.module:
-drupal_set_html_head(''.$pngbehaveclasses.' { behavior: url(/'. drupal_get_path('module', 'pngbehave') . '/iepngfix.htc)}');
with:
+global $base_path;
+drupal_set_html_head(''.$pngbehaveclasses.' { behavior: url('. $base_path . drupal_get_path('module', 'pngbehave') . '/iepngfix.htc)}');
the $base_path php variable defaults to '/' and allows for use of pngbehave in subdirectory based drupal installs.
Replaced Line 16 in iepngfix.htc:
-IEPNGFix.blankImg = '/iepngfix/blank.gif';
with:
+IEPNGFix.blankImg = Drupal.settings.basePath + 'sites/all/modules/pngbehave/blank.gif';
NOTE: not sure how else I can inform the js files where to get the blank.gif file from, suggestions welcome.
Commit blank.gif to this build
#5
#6
Cool, it works!
Now that it works, the png's aspect ratio & size is off. Overall I prefer this vs pngfix's way. Thanks for this module!
#7
Thanks, but the real praise goes to Angus Turnbull for the great behavior script.
Now that the reason for this issue is resolved, please open a new issue for the sizing and ration problem. I have been looking into several possible solutions, I'll post more as I find it.
#8
Automatically closed -- issue fixed for two weeks with no activity.