png images get replaced in Opera browser [#34175]

While testing the civicspace theme in the Opera browser (Windows XP), I have noticed that the pngfix.js script is attempting to replace pngs with their Microsoft Internet Explorer equivalents. This is not necessary, as Opera supports alpha-transparent pngs. On some occasions, I have also noticed that the png images in Opera disappear completely, making underlying elements invisible.

This patch should correct this problem, as Opera's navigator.userAgent string always contains the string "Opera" and the opera version number, even when its masquerading as other browsers such as MSIE. I've inserted a check for the non-existance of this string before executing the png replacement.

Please check the format of the patch carefully, as its the first one I've submitted here ;)

Comment	File	Size	Author
#5	themes-admin-opera.png	115.9 KB	alan evans
#4	themes-admin-IE.png	150.03 KB	alan evans
#3	themes-admin-firefox.png	183.45 KB	alan evans
	pngfix-opera-patch.txt	1.13 KB	alan evans

Comments

Comment #1

robin monks commented 20 October 2005 at 16:19

I did some various tests on Opera 8 with Windows XP without problems. Could you provide some screenshots/testcases/links to show this?

Thanks.

Comment #2

traemccombs commented 21 October 2005 at 14:25

Sent email to Alan asking for update on status of this bug.
Trae

Comment #3

alan evans commented 22 October 2005 at 17:52

Status	File	Size
new	themes-admin-firefox.png	183.45 KB

I am attaching 3 screenshots of the same page (admin/themes) in Firefox, Internet Explorer, and Opera. Note the missing screenshot thumbnails in Opera.

Note that Opera will only show this behaviour when masquerading as MSIE (Using Opera version 8.5 for Windows XP, this is set in the tools menu under preferences, on the advanced tab under "network"). This appears to be the default setting for Windows installations of the free version, as I have made no changes to the settings in Opera.